-
Notifications
You must be signed in to change notification settings - Fork 73
Open
Description
Hi!
First off, thanks for providing and maintaining this library!
I noticed that GoogleTests is checked in as a part of the source and I'd like to suggest that CMake's ExternalProject feature could be used instead. It would allow cppfs to checkout and include it in the configure process. Additionally, this could become optional based on if find_package() cannot find an already installed GTest library on the host.
Please see GoogleTest readme for more information: Incorporating Into An Existing CMake Project (https://github.com/google/googletest/blob/4f4c01d8c86659f587ea0bc27c815ffa94fc9f72/googletest/README.md)
Main benefits include
- 3rd party code is not checked in
cppfsno longer need to updateGoogleTestthem self.cppfscould easily point to specific git tag or branch ofGoogleTestGoogleTestssource is not included ifOPTION_for tests is ON- If installed on host, Linking is easy as
find_package(GTest WANTED_VERSION EXACT)andtarget_link_librarieswithGTest::GTestandGTest::Main - If GoogleTests is downloaded and added to the project like suggested, just call
target_link_librarieswithgtestandgtest_main
If this sounds reasonable I would be happy to help out by sending a PR or further instructions.
Best regards
Metadata
Metadata
Assignees
Labels
No labels