Skip to content

Conversation

@notshekhar
Copy link
Contributor

Added a new action to branch out from an existing chat thread, creating a new thread with the selected message and linking it to the parent thread. Updated UI components to support this feature, including the addition of a GitBranch icon for visual representation of parent threads.

Added a new action to branch out from an existing chat thread, creating a new thread with the selected message and linking it to the parent thread. Updated UI components to support this feature, including the addition of a GitBranch icon for visual representation of parent threads.
@vercel
Copy link

vercel bot commented Jul 13, 2025

@notshekhar is attempting to deploy a commit to the cgoinglove's projects Team on Vercel.

A member of the Team first needs to authorize it.

@notshekhar
Copy link
Contributor Author

Screenshot 2025-07-13 at 20 33 40 Screenshot 2025-07-13 at 20 33 47

Updated the ChatThread type to make parentThreadId optional and modified the chat repository to default it to null if not provided. This change improves the handling of chat threads without a parent.
@brrock
Copy link
Collaborator

brrock commented Jul 15, 2025

Nice, thanks for your support on this project

Copy link
Collaborator

@brrock brrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the prettier file

@brrock brrock requested review from brrock and cgoinglove July 15, 2025 06:50
@notshekhar
Copy link
Contributor Author

notshekhar commented Jul 15, 2025

Okay, I'll remove the Prettier configuration file. I originally created it to ensure the entire team shares a consistent Prettier setup. otherwise, my local Prettier would reformat files in a completely different style. @brrock

@brrock
Copy link
Collaborator

brrock commented Jul 15, 2025

We use biome, it probably run using lint staged so could you use that, pnpm format

@cgoinglove
Copy link
Owner

Thank you for your valuable contribution with this new feature, 'feat: implement branching functionality for chat threads'. We truly appreciate your effort.

However, regarding the thread branching functionality, I already have a specific UI and architectural design in mind, which you can see referenced below:

image

After careful consideration, it appears that the current implementation in this PR differs somewhat from the envisioned design. Therefore, it would be challenging to merge this pull request as it is.

For future feature contributions, to ensure alignment and avoid such discrepancies, it would be greatly beneficial if we could discuss the direction and scope through a GitHub issue first before development begins.

Thank you again for your understanding and continued interest in the project.

Changed the model reference for "gemini-2.5-flash" from "gemini-2.5-flash-preview-04-17" to "gemini-2.5-flash" for consistency and accuracy in model usage.
Eliminated the mention display section from the PromptInput component to streamline the UI and improve maintainability. This change focuses on enhancing the overall user experience by simplifying the component structure.
{
"singleQuote": false,
"tabWidth": 2,
"trailingComma": "all",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"trailingComma": "all",
"trailingComma": "all",

Please switch our biome config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants