Commit 94db58f
fix:
As pointed out #1429, the `pkg_manifest_minimal` example was calling
`ComplexClass.greet()` and printing the result, but the function did not
return anything. Instead, it was printing in `greet()` function. That
was not the original intent. I updated `ComplexClass.greet()` to return
the greeting so that the executable can print it. I also added a check
in `do_test` to confirm that it was being output properly. All of this
was a miss on my part.
Thanks to @0xLucasMarcal for pointing this.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>pkg_manifest_minimal example (#1458)1 parent 17f923c commit 94db58f
File tree
2 files changed
+3
-2
lines changed- examples/pkg_manifest_minimal
- third_party/NotThatAmazingModule/Sources/NotThatAmazingModule
2 files changed
+3
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments