Address code review feedback: formatting and style improvements

- Update .bazelrc files to use shared config imports
- Update do_test script to use BIT_BAZEL_BINARY
- Wrap long lines in MODULE.bazel to stay under 80 chars
- Refactor framework detection with helper function and constants
- Move header extensions to constants
- Improve line wrapping and formatting throughout

Author: codeman9

examples/aws_crt_example/.bazelrc

@@ -1,4 +1,8 @@
-build --enable_bzlmod
-build --lockfile_mode=update
-build --macos_minimum_os=15.0
-build --host_macos_minimum_os=15.0
+# Import Shared settings
+import %workspace%/../../shared.bazelrc
+
+# Import CI settings.
+import %workspace%/../../ci.bazelrc
+
+# Try to import a local.rc file; typically, written by CI
+try-import %workspace%/../../local.bazelrc

examples/aws_crt_example/MODULE.bazel

@@ -7,8 +7,16 @@ local_path_override(
 )
 
 bazel_dep(name = "apple_support", version = "1.24.2")
-bazel_dep(name = "rules_swift", version = "3.1.2", repo_name = "build_bazel_rules_swift")
-bazel_dep(name = "rules_apple", version = "4.2.0", repo_name = "build_bazel_rules_apple")
+bazel_dep(
+    name = "rules_swift",
+    version = "3.1.2",
+    repo_name = "build_bazel_rules_swift",
+)
+bazel_dep(
+    name = "rules_apple",
+    version = "4.2.0",
+    repo_name = "build_bazel_rules_apple",
+)
 
 apple_cc_configure = use_extension(
     "@apple_support//crosstool:setup.bzl",

examples/aws_crt_example/do_test

@@ -2,4 +2,9 @@
 
 set -euo pipefail
 
-bazel test //...
+# Use the Bazel binary specified by the integration test. Otherise, fall back
+# to bazel.
+bazel="${BIT_BAZEL_BINARY:-bazel}"
+
+# Ensure that it builds and tests pass
+"${bazel}" test //...

examples/aws_sdk_example/.bazelrc

@@ -1,4 +1,8 @@
-build --enable_bzlmod
-build --lockfile_mode=update
-build --macos_minimum_os=15.0
-build --host_macos_minimum_os=15.0
+# Import Shared settings
+import %workspace%/../../shared.bazelrc
+
+# Import CI settings.
+import %workspace%/../../ci.bazelrc
+
+# Try to import a local.rc file; typically, written by CI
+try-import %workspace%/../../local.bazelrc

swiftpkg/internal/module_maps.bzl

@@ -110,7 +110,11 @@ def write_module_map(
         _add_headers(headers = [umbrella_header], kind = "umbrella header")
     elif umbrella_directory:
         # Umbrella directory must be absolute path
-        abs_umbrella = back_to_root_path + umbrella_directory if back_to_root_path else umbrella_directory
+        abs_umbrella = (
+            back_to_root_path + umbrella_directory
+            if back_to_root_path
+            else umbrella_directory
+        )
         content.add(abs_umbrella, format = '    umbrella "%s"')
     else:
         _add_headers(headers = public_headers, kind = "header")

swiftpkg/internal/pkginfos.bzl

@@ -1174,15 +1174,21 @@ def _new_swift_src_info(
 
 # MARK: - Clang Source Info
 
+_FRAMEWORK_SRC_EXTS = [".c", ".cc", ".cpp", ".m", ".mm", ".h", ".hpp"]
+_HEADER_EXTS = [".h", ".hpp", ".hh", ".hxx", ".inc", ".inl", ".modulemap"]
+
+def _is_framework_src(path):
+    _root, ext = paths.split_extension(path)
+    return lists.contains(_FRAMEWORK_SRC_EXTS, ext)
+
 def _detect_frameworks_from_sources(repository_ctx, srcs):
-    """Detect Apple frameworks from #include <Framework/Header.h> patterns in C source files."""
+    """Detect Apple frameworks from #include <Framework/Header.h> patterns in \
+    C source files."""
     frameworks_set = sets.make()
 
     for src in srcs:
         # Only scan C/C++/ObjC source and header files
-        if not (src.endswith(".c") or src.endswith(".cc") or src.endswith(".cpp") or
-                src.endswith(".m") or src.endswith(".mm") or src.endswith(".h") or
-                src.endswith(".hpp")):
+        if not _is_framework_src(src):
             continue
 
         # Read the file and look for framework includes
@@ -1191,21 +1197,25 @@ def _detect_frameworks_from_sources(repository_ctx, srcs):
         for line in lines:
             line = line.strip()
 
-            # Look for #include <Framework/Header.h> or #import <Framework/Header.h>
-            if line.startswith("#include") or line.startswith("#import"):
-                # Extract the include path
-                if "<" in line and ">" in line:
-                    start = line.index("<") + 1
-                    end = line.index(">")
-                    include_path = line[start:end]
+            # Look for #include <Framework/Header.h> or
+            # #import <Framework/Header.h>
+            if not line.startswith("#include") and \
+               not line.startswith("#import"):
+                continue
 
-                    # Check if it's a framework include (has a slash)
-                    if "/" in include_path:
-                        framework = include_path.split("/")[0]
+            # Extract the include path
+            if "<" in line and ">" in line:
+                start = line.index("<") + 1
+                end = line.index(">")
+                include_path = line[start:end]
 
-                        # Check if it's a known Apple framework
-                        if sets.contains(apple_builtin.frameworks.all, framework):
-                            sets.insert(frameworks_set, framework)
+                # Check if it's a framework include (has a slash)
+                if "/" in include_path:
+                    framework = include_path.split("/")[0]
+
+                    # Check if it's a known Apple framework
+                    if sets.contains(apple_builtin.frameworks.all, framework):
+                        sets.insert(frameworks_set, framework)
 
     return sorted(sets.to_list(frameworks_set))
 
@@ -1229,7 +1239,9 @@ def _new_clang_src_info_from_sources(
     # Also remove any exclude patterns that would exclude the include directory,
     # since SPM doesn't exclude public headers even if they're in the exclude list.
     if public_hdrs_path == None:
-        default_include_path = paths.normalize(paths.join(abs_target_path, "include"))
+        default_include_path = paths.normalize(
+            paths.join(abs_target_path, "include"),
+        )
         if repository_files.is_directory(repository_ctx, default_include_path):
             public_hdrs_path = "include"
 
@@ -1303,7 +1315,7 @@ def _new_clang_src_info_from_sources(
             # Filter to only header files
             for f in excluded_files:
                 _, ext = paths.split_extension(f)
-                if ext in [".h", ".hpp", ".hh", ".hxx", ".inc", ".inl", ".modulemap"]:
+                if ext in _HEADER_EXTS:
                     all_srcs.append(f)
 
     # Organize the source files