fix isAuthenticated logic in auth provider, remove legacyBehavior link props, fix ux for setting isLoading after joining an organization

Author: chad-syntax

src/components/modals/join-organization.tsx

@@ -44,18 +44,20 @@ export function JoinOrganizationModal({ open, onOpenChange }: JoinOrganizationMo
         setErrors({
           'join-organization': [result.message || 'Failed to join organization'],
         });
+        setLoading(false);
       } else if (result.errors) {
         setErrors(result.errors);
+        setLoading(false);
       } else {
         setErrors({
           'join-organization': ['Failed to join organization'],
         });
+        setLoading(false);
       }
     } catch (error: any) {
       setErrors({
         'join-organization': [error?.message || 'Failed to join organization'],
       });
-    } finally {
       setLoading(false);
     }
   };

src/components/roadmap/propose-cta.tsx

@@ -26,7 +26,7 @@ export const RoadmapProposeCta = (props: RoadmapProposeCtaProps) => {
       Propose Feature
     </Button>
   ) : (
-    <Link href={routes.auth.signIn} passHref legacyBehavior>
+    <Link href={routes.auth.signIn}>
       <Button
         asChild
         onClick={() => toast.info('You must be logged in to propose a feature')}

src/components/roadmap/vote-cta.tsx

@@ -43,7 +43,7 @@ export const RoadmapVoteCta = (props: RoadmapVoteCta) => {
 
   if (!currentUserId) {
     return (
-      <Link href={routes.auth.signIn} passHref legacyBehavior>
+      <Link href={routes.auth.signIn}>
         <Button
           asChild
           variant="ghost"

src/providers/auth.tsx

@@ -50,7 +50,7 @@ export const AuthProvider = (props: AuthProviderProps) => {
       } = await supabase.auth.getUser();
 
       setUser(userFromSupabase);
-      setIsAuthenticated(Boolean(user));
+      setIsAuthenticated(Boolean(userFromSupabase));
 
       if (userFromSupabase) {
         const { data: agentsmithUser } = await supabase