fixing Strava integration issues

Author: chadbeaudin

app/api/strava/activities/route.ts

@@ -21,6 +21,9 @@ export async function POST(req: Request) {
         return NextResponse.json({ riddenRoads });
     } catch (error: any) {
         console.error('Strava Fetch Error:', error);
-        return NextResponse.json({ error: error.message }, { status: 500 });
+        return NextResponse.json({
+            error: error.message,
+            trace: error.stack
+        }, { status: 500 });
     }
 }

app/page.tsx

@@ -70,11 +70,13 @@ export default function Home() {
                     setStravaRoads(data.riddenRoads);
                 } else if (data.error) {
                     setStravaError(data.error);
+                    setError({ message: data.error, trace: data.trace });
                 }
             })
             .catch(err => {
                 console.error('Failed to fetch Strava roads:', err);
                 setStravaError(err.message);
+                setError({ message: `Strava Connection Failed: ${err.message}` });
             });
     }, [stravaCredentials]);
 
@@ -682,6 +684,14 @@ ${route.map(pt => `      <trkpt lat="${pt[1]}" lon="${pt[0]}">${pt[2] !== undefi
                         // No need to close, let them see the "Saved!" state
                     }}
                 />
+
+                {error && (
+                    <ErrorDialog
+                        message={error.message}
+                        trace={error.trace}
+                        onClose={() => setError(null)}
+                    />
+                )}
             </div>
         </main>
     );

components/StravaSettingsDialog.tsx

@@ -80,6 +80,10 @@ export function StravaSettingsDialog({ isOpen, onClose, onSave }: StravaSettings
                                         https://www.strava.com/oauth/authorize?client_id=YOUR_CLIENT_ID&response_type=code&redirect_uri=http://localhost&approval_prompt=force&scope=read,activity:read_all
                                     </div>
                                 </li>
+                                <li className="text-amber-800 font-semibold bg-amber-50 p-2 rounded border border-amber-100">
+                                    <Check className="w-3 h-3 inline mr-1" />
+                                    IMPORTANT: On the authorization page, you MUST check all the boxes (especially &quot;View data about your activities&quot; and &quot;View data about your private activities&quot;) or the app will not be able to fetch your data.
+                                </li>
                                 <li> Authorize the app, then you will be redirected to a localhost URL. Copy the <code>code</code> parameter from the URL.</li>
                                 <li> Run this command in your terminal (mac/linux) to get the refresh token:
                                     <div className="mt-2 p-2 bg-indigo-100/50 rounded font-mono text-[10px] break-all border border-indigo-200 overflow-x-auto whitespace-pre">

lib/strava.ts

@@ -8,12 +8,18 @@ export interface StravaActivity {
 }
 
 export async function getStravaAccessToken(creds?: { clientId?: string; clientSecret?: string; refreshToken?: string }) {
-    const clientId = creds?.clientId || process.env.STRAVA_CLIENT_ID;
-    const clientSecret = creds?.clientSecret || process.env.STRAVA_CLIENT_SECRET;
-    const refreshToken = creds?.refreshToken || process.env.STRAVA_REFRESH_TOKEN;
+    // Check if we received any non-empty credentials in the UI object
+    const hasUICreds = !!(creds && (creds.clientId || creds.clientSecret || creds.refreshToken));
+
+    const clientId = (creds?.clientId) || process.env.STRAVA_CLIENT_ID;
+    const clientSecret = (creds?.clientSecret) || process.env.STRAVA_CLIENT_SECRET;
+    const refreshToken = (creds?.refreshToken) || process.env.STRAVA_REFRESH_TOKEN;
+
+    const source = hasUICreds ? 'UI' : 'ENV';
+    console.log(`[Strava] Attempting token refresh. Source: ${source}, ClientID: ${clientId?.substring(0, 5)}..., Token: ${refreshToken?.substring(0, 8)}...`);
 
     if (!clientId || !clientSecret || !refreshToken) {
-        throw new Error('Missing Strava credentials. Please configure them in Settings.');
+        throw new Error(`Missing Strava credentials (${source}). Please configure them in Settings or your environment variables.`);
     }
 
     const params = new URLSearchParams();
@@ -44,9 +50,18 @@ export async function getStravaAccessToken(creds?: { clientId?: string; clientSe
     }
 
     const data = await response.json();
+    const scopes = data.scope || 'NOT_RETURNED';
+    console.log(`[Strava] Refresh successful. Scopes received: ${scopes}. Response keys: ${Object.keys(data).join(', ')}`);
+
     if (!data.access_token) {
         throw new Error('Strava token refresh response did not contain an access_token');
     }
+
+    // Check for activity read permission in the scopes
+    if (scopes !== 'NOT_RETURNED' && !scopes.includes('activity:read')) {
+        console.warn(`[Strava] WARNING: Token refreshed but missing 'activity:read' scope. Current permitted scopes: ${scopes}`);
+    }
+
     return data.access_token;
 }