Merge pull request #130 from richardpringle/master

Update superagent to handle expected error responses.

Author: keithamus

lib/request.js

@@ -244,6 +244,9 @@ function Test (app, method, path) {
   Request.call(this, method, path);
   this.app = app;
   this.url = typeof app === 'string' ? app + path : serverAddress(app, path);
+  this.ok(function() {
+    return true;
+  });
 }
 util.inherits(Test, Request);
 

package.json

@@ -50,7 +50,7 @@
     "is-ip": "1.0.0",
     "methods": "^1.1.2",
     "qs": "^6.2.0",
-    "superagent": "^2.0.0"
+    "superagent": "^3.3.0"
   },
   "devDependencies": {
     "simplifyify": "^2.0.1",

test/request.js

@@ -74,6 +74,15 @@ describe('request', function () {
         });
     });
 
+    it('succeeds when response has an error status', function (done) {
+      request('https://httpbin.org')
+        .get('/status/400')
+        .end(function (err, res) {
+          res.should.have.status(400);
+          done(err);
+        });
+    });
+
     it('can be augmented with promises', function (done) {
       request('https://httpbin.org')
         .get('/get')
@@ -93,6 +102,14 @@ describe('request', function () {
         })
         .then(done, done);
     });
+
+    it('can resolve a promise given status code of 400', function () {
+      return request('https://httpbin.org')
+        .get('/status/400')
+        .then(function (res) {
+          res.should.have.status(400);
+        });
+    });
   });
 
   isNode && describe('Node.js', function () {