chore(transport/tcp-tls): small types refactor

Author: thedevbirb

msg-socket/tests/it/reqrep.rs

@@ -84,8 +84,7 @@ async fn reqrep_works() {
 async fn reqrep_tls_works() {
     let _ = tracing_subscriber::fmt::try_init();
 
-    let server_config =
-        tcp_tls::config::Server { ssl_acceptor: helpers::default_acceptor_builder().build() };
+    let server_config = tcp_tls::config::Server::new(helpers::default_acceptor_builder().build());
     let tcp_tls_server = TcpTls::new_server(server_config);
     let mut rep = RepSocket::new(tcp_tls_server);
 
@@ -120,7 +119,7 @@ async fn reqrep_mutual_tls_works() {
     acceptor_builder.set_verify(
         openssl::ssl::SslVerifyMode::PEER | openssl::ssl::SslVerifyMode::FAIL_IF_NO_PEER_CERT,
     );
-    let server_config = tcp_tls::config::Server { ssl_acceptor: acceptor_builder.build() };
+    let server_config = tcp_tls::config::Server::new(acceptor_builder.build());
     let tcp_tls_server = TcpTls::new_server(server_config);
     let mut rep = RepSocket::new(tcp_tls_server);
 

msg-transport/src/tcp_tls/config.rs

@@ -30,6 +30,12 @@ pub struct Server {
     pub ssl_acceptor: SslAcceptor,
 }
 
+impl Server {
+    pub fn new(ssl_acceptor: SslAcceptor) -> Self {
+        Self { ssl_acceptor }
+    }
+}
+
 impl fmt::Debug for Server {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.debug_struct("Server").field("ssl_acceptor", &"SslAcceptor").finish()

msg-transport/src/tcp_tls/mod.rs

@@ -19,7 +19,7 @@ use crate::{Acceptor, PeerAddress, Transport, TransportExt};
 
 pub mod config;
 
-/// An invalid operation, due to using as a server or viceversa.
+/// An invalid operation, due to using a client as a server or viceversa.
 #[derive(Debug, Clone, Copy, thiserror::Error)]
 pub enum InvalidOperation {
     #[error("tried to bind as a client")]
@@ -48,9 +48,15 @@ pub enum Error {
 }
 
 /// A TCP-TLS client.
-#[derive(Debug, Clone, From, Deref, DerefMut)]
+#[derive(Debug, Clone, Deref, DerefMut)]
 pub struct Client(config::Client);
 
+impl Client {
+    pub fn new(config: config::Client) -> Self {
+        Self(config)
+    }
+}
+
 /// A TCP-TLS server.
 pub struct Server {
     /// The underlying TCP listener.
@@ -59,6 +65,12 @@ pub struct Server {
     acceptor: Arc<SslAcceptor>,
 }
 
+impl Server {
+    pub fn new(acceptor: SslAcceptor) -> Self {
+        Self { listener: None, acceptor: Arc::new(acceptor) }
+    }
+}
+
 impl fmt::Debug for Server {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.debug_struct("Server")
@@ -78,12 +90,12 @@ pub enum TcpTls {
 impl TcpTls {
     /// Create a new instance of the transport with client configuration.
     pub fn new_client(config: config::Client) -> Self {
-        TcpTls::Client(config.into())
+        TcpTls::Client(Client::new(config))
     }
 
     /// Create a new instance of the transport with server configuration.
     pub fn new_server(config: config::Server) -> Self {
-        TcpTls::Server(Server { listener: None, acceptor: Arc::new(config.ssl_acceptor) })
+        TcpTls::Server(Server::new(config.ssl_acceptor))
     }
 
     pub fn as_client(&self) -> Option<&Client> {