Skip to content

Migrate from go-yara to yara-x; improve performance and readability #2268

Migrate from go-yara to yara-x; improve performance and readability

Migrate from go-yara to yara-x; improve performance and readability #2268

Triggered via pull request December 22, 2024 05:44
Status Failure
Total duration 6m 18s
Artifacts 1
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

style.yaml

on: pull_request
check yr compile
13s
check yr compile
check yr fmt
16s
check yr fmt
check gofmt
15s
check gofmt
check goimports
23s
check goimports
golangci-lint
4m 58s
golangci-lint
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 2 warnings
check gofmt: pkg/action/scan_test.go#L1
Please run gofmt -s. diff --git a/pkg/action/scan_test.go b/pkg/action/scan_test.go index 774a60a..291208e 100644 --- a/pkg/action/scan_test.go +++ b/pkg/action/scan_test.go @@ -9,10 +9,10 @@ import ( func TestCleanPath(t *testing.T) { tests := []struct { - name string - path string - prefix string - want string + name string + path string + prefix string + want string }{ { name: "expected behavior", @@ -33,9 +33,9 @@ func TestCleanPath(t *testing.T) { want: "/test.txt", }, { - name: "non-existent path", - path: "does_not_exist/test.txt", - prefix: "temp", + name: "non-existent path", + path: "does_not_exist/test.txt", + prefix: "temp", }, { name: "path prefix mismatch",
check gofmt
Process completed with exit code 1.
check yr fmt
Process completed with exit code 123.
check goimports: pkg/action/scan_test.go#L1
Please run goimports. diff --git a/pkg/action/scan_test.go b/pkg/action/scan_test.go index 774a60a..291208e 100644 --- a/pkg/action/scan_test.go +++ b/pkg/action/scan_test.go @@ -9,10 +9,10 @@ import ( func TestCleanPath(t *testing.T) { tests := []struct { - name string - path string - prefix string - want string + name string + path string + prefix string + want string }{ { name: "expected behavior", @@ -33,9 +33,9 @@ func TestCleanPath(t *testing.T) { want: "/test.txt", }, { - name: "non-existent path", - path: "does_not_exist/test.txt", - prefix: "temp", + name: "non-existent path", + path: "does_not_exist/test.txt", + prefix: "temp", }, { name: "path prefix mismatch",
check goimports
Process completed with exit code 1.
check goimports
Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
golangci-lint: pkg/report/report.go#L312
Comment should end in a period (godot)
golangci-lint: pkg/report/report.go#L327
Comment should end in a period (godot)
golangci-lint: pkg/report/report.go#L334
Comment should end in a period (godot)
golangci-lint: pkg/report/report.go#L369
type assertion must be checked (forcetypeassert)
golangci-lint: pkg/report/report.go#L370
SA6002: argument should be pointer-like to avoid allocations (staticcheck)
golangci-lint
issues found
check yr compile
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
check yr fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size Digest
diff Expired
461 Bytes
sha256:8582b9ba289de8dc605af460e79ab5a9bc392dbd48d0e569d93bebb6b7da84e6