Skip to content

Commit 033f21a

Browse files
authored
feat(integrations): show default values (#1696)
Signed-off-by: Miguel Martinez <[email protected]>
1 parent f83a212 commit 033f21a

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

app/cli/cmd/available_integration_describe.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,12 @@ func renderSchemaTable(tableTitle string, properties sdk.SchemaPropertiesMap) er
122122
color = text.Colors{text.FgHiYellow}
123123
}
124124

125-
required := "no"
126-
if v.Required {
127-
required = "yes"
125+
var requiredInfo = color.Sprint(hBool(v.Required))
126+
if v.Default != "" && !v.Required {
127+
requiredInfo = fmt.Sprintf("%s (default: %s)", requiredInfo, v.Default)
128128
}
129129

130-
t.AppendRow(table.Row{color.Sprint(v.Name), color.Sprint(propertyType), color.Sprint(required), v.Description})
130+
t.AppendRow(table.Row{color.Sprint(v.Name), color.Sprint(propertyType), requiredInfo, v.Description})
131131
}
132132

133133
t.Render()

app/controlplane/plugins/sdk/v1/fanout.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,8 @@ type SchemaProperty struct {
443443
// If the property is required
444444
Required bool
445445
// Optional format (email, host)
446-
Format string
446+
Format string
447+
Default string
447448
}
448449

449450
func CompileJSONSchema(in []byte) (*schema_validator.Schema, error) {
@@ -493,12 +494,19 @@ func CalculatePropertiesMap(s *schema_validator.Schema, m *SchemaPropertiesMap)
493494
}
494495

495496
var required = requiredMap[k]
497+
498+
var defaultVal string
499+
if v.Default != nil && !required {
500+
defaultVal = fmt.Sprintf("%v", v.Default)
501+
}
502+
496503
(*m)[k] = &SchemaProperty{
497504
Name: k,
498505
Type: v.Types[0],
499506
Required: required,
500507
Description: v.Description,
501508
Format: v.Format,
509+
Default: defaultVal,
502510
}
503511
}
504512
}

0 commit comments

Comments
 (0)