fix: nil pointer guard when no attestation is present (#185)

migmartri · web-flow · commit 3e527226d20d · 2023-06-19T12:40:19.000+02:00
Signed-off-by: Miguel Martinez Trivino &lt;miguel@chainloop.dev&gt;
diff --git a/app/controlplane/internal/service/attestation.go b/app/controlplane/internal/service/attestation.go
@@ -244,7 +244,7 @@ func (s *AttestationService) GetUploadCreds(ctx context.Context, _ *cpAPI.Attest
 }
 
 func bizAttestationToPb(att *biz.Attestation) (*cpAPI.AttestationItem, error) {
-	if att.Envelope == nil {
+	if att == nil || att.Envelope == nil {
 		return nil, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ func (s AttestationService) GetUploadCreds(ctx context.Context, _ cpAPI.Attest`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`func bizAttestationToPb(att biz.Attestation) (cpAPI.AttestationItem, error) {`
`247`		`- if att.Envelope == nil {`
	`247`	`+ if att == nil \|\| att.Envelope == nil {`
`248`	`248`	`return nil, nil`
`249`	`249`	`}`
`250`	`250`