Improve error reporting from plugins loading (#2216)

Signed-off-by: Rafał Kuć <[email protected]>

Author: gr0

app/cli/cmd/root.go

@@ -247,7 +247,7 @@ func NewRootCmd(l zerolog.Logger) *cobra.Command {
 
 	// Load plugins if we are not running a subcommand
 	if len(os.Args) > 1 && os.Args[1] != "completion" && os.Args[1] != "help" {
-		pluginManager = plugins.NewManager()
+		pluginManager = plugins.NewManager(&logger)
 		if err := loadAllPlugins(rootCmd); err != nil {
 			logger.Error().Err(err).Msg("Failed to load plugins, continuing with built-in commands only")
 		}

app/cli/pkg/plugins/manager.go

@@ -23,12 +23,14 @@ import (
 
 	"github.com/hashicorp/go-hclog"
 	"github.com/hashicorp/go-plugin"
+	"github.com/rs/zerolog"
 )
 
 // Manager handles loading and managing plugins.
 type Manager struct {
 	plugins       map[string]*LoadedPlugin
 	pluginClients map[string]*plugin.Client
+	logger        *zerolog.Logger
 }
 
 // LoadedPlugin represents a loaded plugin with its metadata.
@@ -39,10 +41,11 @@ type LoadedPlugin struct {
 }
 
 // NewManager creates a new plugin manager.
-func NewManager() *Manager {
+func NewManager(logger *zerolog.Logger) *Manager {
 	return &Manager{
 		plugins:       make(map[string]*LoadedPlugin),
 		pluginClients: make(map[string]*plugin.Client),
+		logger:        logger,
 	}
 }
 
@@ -62,7 +65,8 @@ func (m *Manager) LoadPlugins(ctx context.Context) error {
 	for _, plugin := range plugins {
 		// Load the plugin - if there is an error just skip it - we can think of a better strategy later
 		if err := m.loadPlugin(ctx, plugin); err != nil {
-			fmt.Printf("failed to load plugin: %s\n", err)
+			m.logger.Error().Msgf("failed to load plugin: %s", plugin)
+			m.logger.Debug().Err(err).Msgf("plugin loading failure reason: %s", plugin)
 			continue
 		}
 	}