feat(cli): show skipped policies (#1707)

Signed-off-by: Miguel Martinez <[email protected]>

Author: migmartri

app/cli/cmd/attestation_status.go

@@ -113,16 +113,16 @@ func attestationStatusTableOutput(status *action.AttestationStatusResult, full b
 		}
 	}
 
+	var blockingColor text.Color
+	var blockingText = "ADVISORY"
+	if status.MustBlockOnPolicyViolations {
+		blockingColor = text.FgHiYellow
+		blockingText = "ENFORCED"
+	}
+	gt.AppendRow(table.Row{"Policy violation strategy", blockingColor.Sprint(blockingText)})
+
 	evs := status.PolicyEvaluations[chainloop.AttPolicyEvaluation]
 	if len(evs) > 0 {
-		var blockingColor text.Color
-		var blockingText = "ADVISORY"
-		if status.MustBlockOnPolicyViolations {
-			blockingColor = text.FgHiYellow
-			blockingText = "ENFORCED"
-		}
-
-		gt.AppendRow(table.Row{"Policy violation strategy", blockingColor.Sprint(blockingText)})
 		gt.AppendRow(table.Row{"Policies", "------"})
 		policiesTable(evs, gt)
 	}

app/cli/cmd/workflow_workflow_run_describe.go

@@ -231,28 +231,34 @@ func predicateV1Table(att *action.WorkflowRunAttestationItem) {
 
 func policiesTable(evs []*action.PolicyEvaluation, mt table.Writer) {
 	for _, ev := range evs {
-		color := text.Colors{text.FgHiRed}
-		var violations []string
-		var prefix = ""
-		if len(ev.Violations) > 0 {
+		msg := ""
+
+		switch {
+		case ev.Skipped:
+			msg = text.Colors{text.FgHiYellow}.Sprintf("skipped - %s", strings.Join(ev.SkipReasons, ", "))
+		case len(ev.Violations) == 0:
+			msg = text.Colors{text.FgHiGreen}.Sprint("Ok")
+		case len(ev.Violations) > 0:
+			color := text.Colors{text.FgHiRed}
+			var violations []string
+			var prefix = ""
 			for _, v := range ev.Violations {
 				violations = append(violations, v.Message)
 			}
 			// For multiple violations, we want to indent the list
 			if len(violations) > 1 {
 				prefix = "\n  - "
 			}
-		} else {
-			violations = append(violations, "Ok")
-			color = text.Colors{text.FgHiGreen}
-		}
 
-		// Color the violations text before joining
-		for i, v := range violations {
-			violations[i] = color.Sprint(v)
+			// Color the violations text before joining
+			for i, v := range violations {
+				violations[i] = color.Sprint(v)
+			}
+
+			msg = strings.Join(violations, prefix)
 		}
 
-		mt.AppendRow(table.Row{"", fmt.Sprintf("%s: %s", ev.Name, prefix+strings.Join(violations, prefix))})
+		mt.AppendRow(table.Row{"", fmt.Sprintf("%s: %s", ev.Name, msg)})
 	}
 }