handle rollbacks (#1586)

Signed-off-by: Miguel Martinez <[email protected]>

Author: migmartri

app/controlplane/pkg/data/casbackend.go

@@ -83,12 +83,19 @@ func (r *CASBackendRepo) FindFallbackBackend(ctx context.Context, orgID uuid.UUI
 
 // Create creates a new CAS backend in the given organization
 // If it's set as default, it will unset the previous default backend
-func (r *CASBackendRepo) Create(ctx context.Context, opts *biz.CASBackendCreateOpts) (*biz.CASBackend, error) {
+func (r *CASBackendRepo) Create(ctx context.Context, opts *biz.CASBackendCreateOpts) (b *biz.CASBackend, err error) {
 	tx, err := r.data.DB.Tx(ctx)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create transaction: %w", err)
 	}
 
+	defer func() {
+		// Unblock the row if there was an error
+		if err != nil {
+			_ = tx.Rollback()
+		}
+	}()
+
 	// 1 - unset default backend for all the other backends in the org
 	if opts.Default {
 		if err := tx.CASBackend.Update().
@@ -129,12 +136,19 @@ func (r *CASBackendRepo) Create(ctx context.Context, opts *biz.CASBackendCreateO
 	return r.FindByID(ctx, backend.ID)
 }
 
-func (r *CASBackendRepo) Update(ctx context.Context, opts *biz.CASBackendUpdateOpts) (*biz.CASBackend, error) {
+func (r *CASBackendRepo) Update(ctx context.Context, opts *biz.CASBackendUpdateOpts) (b *biz.CASBackend, err error) {
 	tx, err := r.data.DB.Tx(ctx)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create transaction: %w", err)
 	}
 
+	defer func() {
+		// Unblock the row if there was an error
+		if err != nil {
+			_ = tx.Rollback()
+		}
+	}()
+
 	// 1 - unset default backend for all the other backends in the org
 	if opts.Default {
 		if err := tx.CASBackend.Update().

app/controlplane/pkg/data/integration.go

@@ -112,12 +112,19 @@ func (r *IntegrationRepo) FindByNameInOrg(ctx context.Context, orgID uuid.UUID,
 	return entIntegrationToBiz(integration), nil
 }
 
-func (r *IntegrationRepo) SoftDelete(ctx context.Context, id uuid.UUID) error {
+func (r *IntegrationRepo) SoftDelete(ctx context.Context, id uuid.UUID) (err error) {
 	tx, err := r.data.DB.Tx(ctx)
 	if err != nil {
 		return err
 	}
 
+	defer func() {
+		// Unblock the row if there was an error
+		if err != nil {
+			_ = tx.Rollback()
+		}
+	}()
+
 	// soft-delete attachments associated with this workflow
 	if err := tx.IntegrationAttachment.Update().Where(integrationattachment.HasIntegrationWith(integration.ID(id))).SetDeletedAt(time.Now()).Exec(ctx); err != nil {
 		return err

app/controlplane/pkg/data/membership.go

@@ -145,7 +145,7 @@ func (r *MembershipRepo) FindByIDInOrg(ctx context.Context, orgID, membershipID
 	return entMembershipToBiz(m), nil
 }
 
-func (r *MembershipRepo) SetCurrent(ctx context.Context, membershipID uuid.UUID) (*biz.Membership, error) {
+func (r *MembershipRepo) SetCurrent(ctx context.Context, membershipID uuid.UUID) (mr *biz.Membership, err error) {
 	// Load membership to find user
 	m, err := r.loadMembership(ctx, membershipID)
 	if err != nil {
@@ -158,6 +158,13 @@ func (r *MembershipRepo) SetCurrent(ctx context.Context, membershipID uuid.UUID)
 		return nil, err
 	}
 
+	defer func() {
+		// Unblock the row if there was an error
+		if err != nil {
+			_ = tx.Rollback()
+		}
+	}()
+
 	// 1 - Set all the memberships to current=false
 	if err = tx.Membership.Update().Where(membership.HasUserWith(user.ID(m.Edges.User.ID))).
 		SetCurrent(false).Exec(ctx); err != nil {

app/controlplane/pkg/data/referrer.go

@@ -45,13 +45,20 @@ func NewReferrerRepo(data *Data, wfRepo biz.WorkflowRepo, logger log.Logger) biz
 
 type storedReferrerMap map[string]*ent.Referrer
 
-func (r *ReferrerRepo) Save(ctx context.Context, referrers []*biz.Referrer, workflowID uuid.UUID) error {
+func (r *ReferrerRepo) Save(ctx context.Context, referrers []*biz.Referrer, workflowID uuid.UUID) (err error) {
 	// Start transaction
 	tx, err := r.data.DB.Tx(ctx)
 	if err != nil {
 		return fmt.Errorf("failed to create transaction: %w", err)
 	}
 
+	defer func() {
+		// Unblock the row if there was an error
+		if err != nil {
+			_ = tx.Rollback()
+		}
+	}()
+
 	// find the workflow
 	wf, err := r.workflowRepo.FindByID(ctx, workflowID)
 	if err != nil {

app/controlplane/pkg/data/workflow.go

@@ -314,12 +314,19 @@ func (r *WorkflowRepo) FindByID(ctx context.Context, id uuid.UUID) (*biz.Workflo
 }
 
 // Soft delete workflow, attachments and related projects (if applicable)
-func (r *WorkflowRepo) SoftDelete(ctx context.Context, id uuid.UUID) error {
+func (r *WorkflowRepo) SoftDelete(ctx context.Context, id uuid.UUID) (err error) {
 	tx, err := r.data.DB.Tx(ctx)
 	if err != nil {
 		return err
 	}
 
+	defer func() {
+		// Unblock the row if there was an error
+		if err != nil {
+			_ = tx.Rollback()
+		}
+	}()
+
 	// soft-delete attachments associated with this workflow
 	if err := tx.IntegrationAttachment.Update().Where(integrationattachment.HasWorkflowWith(workflow.ID(id))).SetDeletedAt(time.Now()).Exec(ctx); err != nil {
 		return err