Skip to content

Commit b817df8

Browse files
authored
chore(deployment): add default annotations to Helm Chart (#94)
Signed-off-by: Miguel Martinez Trivino <[email protected]>
1 parent 5d35432 commit b817df8

File tree

3 files changed

+25
-7
lines changed

3 files changed

+25
-7
lines changed

deployment/chainloop/Chart.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ name: chainloop
33
description: Chainloop is an open source software supply chain control plane, a single source of truth for artifacts plus a declarative attestation crafting process.
44

55
type: application
6-
version: 1.1.1
6+
# Bump the patch (not minor, not major) version on each change in the Chart Source code
7+
version: 1.1.2
8+
# Do not update appVersion, this is handled automatically by the release process
79
appVersion: v0.8.99
810

911
dependencies:

deployment/chainloop/README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ This chart bootstraps a [Chainloop](https://github.com/chainloop-dev/chainloop)
1212
- Helm 3.2.0+
1313
- PV provisioner support in the underlying infrastructure (If built-in PostgreSQL is enabled)
1414

15+
Compatibility with the following Ingress Controllers have been checked, others might or might not work.
16+
17+
- [Nginx Ingress Controller](https://kubernetes.github.io/ingress-nginx/)
18+
- [Traefik](https://doc.traefik.io/traefik/providers/kubernetes-ingress/)
19+
1520
## TL;DR
1621

1722
Deploy Chainloop in [development mode](#development) by running
@@ -387,7 +392,7 @@ sentry:
387392
| `controlplane.ingressAPI.hostname` | Default host for the ingress record | `api.cp.dev.local` |
388393
| `controlplane.ingressAPI.ingressClassName` | IngressClass that will be be used to implement the Ingress (Kubernetes 1.18+) | `""` |
389394
| `controlplane.ingressAPI.path` | Default path for the ingress record | `/` |
390-
| `controlplane.ingressAPI.annotations` | Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations. | `{}` |
395+
| `controlplane.ingressAPI.annotations` | Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations. | |
391396
| `controlplane.ingressAPI.tls` | Enable TLS configuration for the host defined at `controlplane.ingress.hostname` parameter | `false` |
392397
| `controlplane.ingressAPI.selfSigned` | Create a TLS secret for this ingress record using self-signed certificates generated by Helm | `false` |
393398
| `controlplane.ingressAPI.extraHosts` | An array with additional hostname(s) to be covered with the ingress record | `[]` |
@@ -432,7 +437,7 @@ sentry:
432437
| `cas.ingressAPI.hostname` | Default host for the ingress record | `api.cp.dev.local` |
433438
| `cas.ingressAPI.ingressClassName` | IngressClass that will be be used to implement the Ingress (Kubernetes 1.18+) | `""` |
434439
| `cas.ingressAPI.path` | Default path for the ingress record | `/` |
435-
| `cas.ingressAPI.annotations` | Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations. | `{}` |
440+
| `cas.ingressAPI.annotations` | Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations. | |
436441
| `cas.ingressAPI.tls` | Enable TLS configuration for the host defined at `controlplane.ingress.hostname` parameter | `false` |
437442
| `cas.ingressAPI.selfSigned` | Create a TLS secret for this ingress record using self-signed certificates generated by Helm | `false` |
438443
| `cas.ingressAPI.extraHosts` | An array with additional hostname(s) to be covered with the ingress record | `[]` |

deployment/chainloop/values.yaml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -292,15 +292,18 @@ controlplane:
292292
## NOTE: You may need to set this to '/*' in order to use this with ALB ingress controllers
293293
##
294294
path: /
295-
## @param controlplane.ingressAPI.annotations Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations.
295+
## @extra controlplane.ingressAPI.annotations Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations.
296296
## Use this parameter to set the required annotations for cert-manager, see
297297
## ref: https://cert-manager.io/docs/usage/ingress/#supported-annotations
298298
## e.g:
299299
## annotations:
300300
## kubernetes.io/controlplane.ingress.class: nginx
301301
## cert-manager.io/cluster-issuer: cluster-issuer-name
302302
##
303-
annotations: {}
303+
annotations:
304+
## @skip controlplane.ingressAPI.annotations.nginx.ingress.kubernetes.io/backend-protocol
305+
## Tell Nginx Ingress Controller to expect gRPC traffic
306+
nginx.ingress.kubernetes.io/backend-protocol: "GRPC"
304307

305308
## @param controlplane.ingressAPI.tls Enable TLS configuration for the host defined at `controlplane.ingress.hostname` parameter
306309
## TLS certificates will be retrieved from a TLS secret with name: `{{- printf "%s-tls" .Values.controlplane.ingress.hostname }}`
@@ -466,15 +469,23 @@ cas:
466469
## NOTE: You may need to set this to '/*' in order to use this with ALB ingress controllers
467470
##
468471
path: /
469-
## @param cas.ingressAPI.annotations Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations.
472+
## @extra cas.ingressAPI.annotations Additional annotations for the Ingress resource. To enable certificate autogeneration, place here your cert-manager annotations.
470473
## Use this parameter to set the required annotations for cert-manager, see
471474
## ref: https://cert-manager.io/docs/usage/ingress/#supported-annotations
472475
## e.g:
473476
## annotations:
474477
## kubernetes.io/controlplane.ingress.class: nginx
475478
## cert-manager.io/cluster-issuer: cluster-issuer-name
476479
##
477-
annotations: {}
480+
annotations:
481+
# Nginx Ingress settings
482+
## @skip cas.ingressAPI.annotations.nginx.ingress.kubernetes.io/proxy-body-size
483+
# Limit file uploads/downloads to 100MB. Alternatively you can disable this limitation by setting it to 0
484+
# Even though we send data in chunks of 1MB, this size refers to all the data sent during the whole streaming session
485+
nginx.ingress.kubernetes.io/proxy-body-size: "100m"
486+
## @skip cas.ingressAPI.annotations.nginx.ingress.kubernetes.io/backend-protocol
487+
## Tell Nginx Ingress Controller to expect gRPC traffic
488+
nginx.ingress.kubernetes.io/backend-protocol: "GRPC"
478489

479490
## @param cas.ingressAPI.tls Enable TLS configuration for the host defined at `controlplane.ingress.hostname` parameter
480491
## TLS certificates will be retrieved from a TLS secret with name: `{{- printf "%s-tls" .Values.controlplane.ingress.hostname }}`

0 commit comments

Comments
 (0)