Adjust plugin describe command output (#2223)

Signed-off-by: Rafał Kuć <[email protected]>

Author: gr0

app/cli/cmd/plugins.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"os"
 	"strconv"
+	"strings"
 
 	"github.com/chainloop-dev/chainloop/app/cli/internal/action"
 	"github.com/chainloop-dev/chainloop/app/cli/pkg/plugins"
@@ -340,28 +341,19 @@ func pluginListTableOutput(plugins map[string]*plugins.LoadedPlugin) {
 
 func pluginInfoTableOutput(plugin *plugins.LoadedPlugin) {
 	t := newTableWriter()
-
-	t.AppendHeader(table.Row{"Name", "Version", "Description", "Commands"})
-	t.AppendRow(table.Row{plugin.Metadata.Name, plugin.Metadata.Version, plugin.Metadata.Description, fmt.Sprintf("%d command(s)", len(plugin.Metadata.Commands))})
-
+	t.SetTitle(fmt.Sprintf("Plugin: %s", plugin.Metadata.Name))
+	t.AppendSeparator()
+	t.AppendRow(table.Row{"Version", plugin.Metadata.Version})
+	t.AppendSeparator()
+	t.AppendRow(table.Row{"Description", plugin.Metadata.Description})
+	t.AppendSeparator()
+	t.AppendRow(table.Row{"Commands", fmt.Sprintf("%d command(s)", len(plugin.Metadata.Commands))})
+	t.AppendSeparator()
 	t.Render()
 
-	pluginInfoCommandsTableOutput(plugin)
 	pluginInfoFlagsTableOutput(plugin)
 }
 
-func pluginInfoCommandsTableOutput(plugin *plugins.LoadedPlugin) {
-	t := newTableWriter()
-
-	t.AppendHeader(table.Row{"Plugin", "Command", "Description", "Usage"})
-	for _, cmd := range plugin.Metadata.Commands {
-		t.AppendRow(table.Row{plugin.Metadata.Name, cmd.Name, cmd.Description, cmd.Usage})
-		t.AppendSeparator()
-	}
-
-	t.Render()
-}
-
 func pluginInfoFlagsTableOutput(plugin *plugins.LoadedPlugin) {
 	if len(plugin.Metadata.Commands) == 0 {
 		return
@@ -378,15 +370,39 @@ func pluginInfoFlagsTableOutput(plugin *plugins.LoadedPlugin) {
 		return
 	}
 
-	t := newTableWriter()
-
-	t.AppendHeader(table.Row{"Plugin", "Command", "Flag", "Description", "Type", "Default", "Required"})
 	for _, cmd := range plugin.Metadata.Commands {
+		t := newTableWriter()
+		t.SetTitle(fmt.Sprintf("Command: %s", cmd.Name))
+		t.AppendSeparator()
+
+		flagDetails := "Flags:\n"
+
+		// Find the longest flag name to align descriptions properly
+		maxFlagLen := 0
 		for _, flag := range cmd.Flags {
-			t.AppendRow(table.Row{plugin.Metadata.Name, cmd.Name, flag.Name, flag.Description, flag.Type, flag.Default, flag.Required})
-			t.AppendSeparator()
+			if len(flag.Name) > maxFlagLen {
+				maxFlagLen = len(flag.Name)
+			}
 		}
-	}
 
-	t.Render()
+		maxFlagLen += 2 // For the "--" prefix
+		for _, flag := range cmd.Flags {
+			shorthand := "   "
+			if flag.Shorthand != "" {
+				shorthand = fmt.Sprintf("-%s,", flag.Shorthand)
+			}
+			flagName := fmt.Sprintf("  %s--%s", shorthand, flag.Name)
+			padding := strings.Repeat(" ", maxFlagLen-len(flag.Name)+2)
+
+			defaultValue := ""
+			if flag.Default != nil {
+				defaultValue = fmt.Sprintf(" (default: %v)", flag.Default)
+			}
+
+			flagDetails += fmt.Sprintf("%s%s%s%s\n", flagName, padding, flag.Description, defaultValue)
+		}
+
+		t.AppendRow(table.Row{flagDetails})
+		t.Render()
+	}
 }