fix(keyless): remove double wrap (#881)

jiparis · web-flow · commit f3880faf8182 · 2024-06-04T18:33:46.000+02:00
Signed-off-by: Jose I. Paris &lt;jiparis@chainloop.dev&gt;
diff --git a/internal/attestation/renderer/renderer.go b/internal/attestation/renderer/renderer.go
@@ -27,7 +27,6 @@ import (
 	"github.com/rs/zerolog"
 	"github.com/secure-systems-lab/go-securesystemslib/dsse"
 	sigstoresigner "github.com/sigstore/sigstore/pkg/signature"
-	sigdsee "github.com/sigstore/sigstore/pkg/signature/dsse"
 	"google.golang.org/protobuf/encoding/protojson"
 )
 
@@ -88,8 +87,7 @@ func (ab *AttestationRenderer) Render() (*dsse.Envelope, error) {
 		return nil, err
 	}
 
-	wrappedSigner := sigdsee.WrapSigner(ab.signer, "application/vnd.in-toto+json")
-	signedAtt, err := wrappedSigner.SignMessage(bytes.NewReader(rawStatement))
+	signedAtt, err := ab.signer.SignMessage(bytes.NewReader(rawStatement))
 	if err != nil {
 		return nil, fmt.Errorf("signing message: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ import (`
`27`	`27`	`"github.com/rs/zerolog"`
`28`	`28`	`"github.com/secure-systems-lab/go-securesystemslib/dsse"`
`29`	`29`	`sigstoresigner "github.com/sigstore/sigstore/pkg/signature"`
`30`		`- sigdsee "github.com/sigstore/sigstore/pkg/signature/dsse"`
`31`	`30`	`"google.golang.org/protobuf/encoding/protojson"`
`32`	`31`	`)`
`33`	`32`
`@@ -88,8 +87,7 @@ func (ab AttestationRenderer) Render() (dsse.Envelope, error) {`
`88`	`87`	`return nil, err`
`89`	`88`	`}`
`90`	`89`
`91`		`- wrappedSigner := sigdsee.WrapSigner(ab.signer, "application/vnd.in-toto+json")`
`92`		`- signedAtt, err := wrappedSigner.SignMessage(bytes.NewReader(rawStatement))`
	`90`	`+ signedAtt, err := ab.signer.SignMessage(bytes.NewReader(rawStatement))`
`93`	`91`	`if err != nil {`
`94`	`92`	`return nil, fmt.Errorf("signing message: %w", err)`
`95`	`93`	`}`