Skip to content

Commit f5505a3

Browse files
authored
feat: do not validate crafting state server-side (#1724)
Signed-off-by: Miguel Martinez <[email protected]>
1 parent 497feb4 commit f5505a3

File tree

5 files changed

+14
-7
lines changed

5 files changed

+14
-7
lines changed

app/controlplane/api/controlplane/v1/attestation_state.pb.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/controlplane/api/controlplane/v1/attestation_state.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ message AttestationStateServiceInitializedResponse {
4646

4747
message AttestationStateServiceSaveRequest {
4848
string workflow_run_id = 1 [(buf.validate.field).string = {min_len: 1}];
49-
attestation.v1.CraftingState attestation_state = 2 [(buf.validate.field).required = true];
49+
// We do not want to validate its content since it might depend on the client-side schema
50+
attestation.v1.CraftingState attestation_state = 2 [(buf.validate.field).ignore = IGNORE_ALWAYS];
5051
// digest of the attestation state this update was performed on top of
5152
// The digest might be empty the first time
5253
string base_digest = 3;

app/controlplane/api/gen/frontend/controlplane/v1/attestation_state.ts

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/controlplane/api/gen/jsonschema/controlplane.v1.AttestationStateServiceSaveRequest.jsonschema.json

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/controlplane/api/gen/jsonschema/controlplane.v1.AttestationStateServiceSaveRequest.schema.json

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)