Skip to content

Commit ff1a028

Browse files
authored
fix: release workflow was missing some secrets (#1590)
Signed-off-by: Jose I. Paris <[email protected]>
1 parent 6798bf3 commit ff1a028

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.github/workflows/build_and_package.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,8 @@ jobs:
154154
tag: ${{ github.ref_name }}
155155
secrets:
156156
chainloop_token: ${{ secrets.CHAINLOOP_TOKEN }}
157+
cosign_key: ${{ secrets.COSIGN_KEY }}
158+
cosign_pass: ${{ secrets.COSIGN_PASSWORD }}
157159
permissions:
158160
packages: write
159161
contents: write

.github/workflows/release.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ on:
99
secrets:
1010
chainloop_token:
1111
required: true
12+
cosign_key:
13+
required: true
14+
cosign_pass:
15+
required: true
1216

1317
jobs:
1418
# This reusable workflow inspects if the given workflow_name exists on Chainloop. If the Workflow does not exist
@@ -71,10 +75,12 @@ jobs:
7175
run: |
7276
chainloop attestation status --full
7377
attestation_sha=$(chainloop attestation push --key env://CHAINLOOP_SIGNING_KEY -o json | jq -r '.digest')
78+
# check that the command succeeded
79+
[ -n "${attestation_sha}" ] || exit 1
7480
echo "attestation_sha=$attestation_sha" >> $GITHUB_OUTPUT
7581
env:
76-
CHAINLOOP_SIGNING_PASSWORD: ${{ secrets.COSIGN_PASSWORD }}
77-
CHAINLOOP_SIGNING_KEY: ${{ secrets.COSIGN_KEY }}
82+
CHAINLOOP_SIGNING_PASSWORD: ${{ secrets.cosign_pass }}
83+
CHAINLOOP_SIGNING_KEY: ${{ secrets.cosign_key }}
7884

7985
- name: Mark attestation as failed
8086
if: ${{ failure() }}

0 commit comments

Comments
 (0)