🐛 fix: Remove Plugin Test Dependencies

Use an ArtifactFilter to only include compile and runtime scope
dependencies. This will exclude all test scope dependencies in
the plugin dependency graph. Maven requires plugins to have their
compile and runtime dependency tree present in the local Maven
repository in order to function.

Assisted-by: Cursor
Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>

Author: adambkaplan

maven_plugin/src/main/java/io/github/chains_project/maven_lockfile/LockFileFacade.java

@@ -24,6 +24,8 @@
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.artifact.DefaultArtifact;
 import org.apache.maven.artifact.factory.ArtifactFactory;
+import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
+import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.project.DefaultProjectBuildingRequest;
 import org.apache.maven.project.MavenProject;
@@ -283,7 +285,11 @@ private static Set<io.github.chains_project.maven_lockfile.graph.DependencyNode>
             dependencyBuildingRequest.setProject(pluginProject);
             dependencyBuildingRequest.setRemoteRepositories(project.getPluginArtifactRepositories());
 
-            var rootNode = dependencyCollectorBuilder.collectDependencyGraph(dependencyBuildingRequest, null);
+            // Filter artifacts to "compile+runtime" scopes. Maven plugins require their runtime
+            // scope dependencies to be present alongside any compile-time dependencies.
+            // Test scope dependencies of plugins should be excluded.
+            ArtifactFilter filter = new ScopeArtifactFilter("compile+runtime");
+            var rootNode = dependencyCollectorBuilder.collectDependencyGraph(dependencyBuildingRequest, filter);
 
             int rootChildren =
                     rootNode.getChildren() != null ? rootNode.getChildren().size() : 0;

maven_plugin/src/test/java/it/IntegrationTestsIT.java

@@ -2,6 +2,7 @@
 
 import static com.soebes.itf.extension.assertj.MavenITAssertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import com.google.common.collect.Ordering;
 import com.soebes.itf.jupiter.extension.MavenJupiterExtension;
@@ -11,6 +12,7 @@
 import io.github.chains_project.maven_lockfile.data.Classifier;
 import io.github.chains_project.maven_lockfile.data.GroupId;
 import io.github.chains_project.maven_lockfile.data.LockFile;
+import io.github.chains_project.maven_lockfile.data.MavenScope;
 import io.github.chains_project.maven_lockfile.data.RepositoryId;
 import io.github.chains_project.maven_lockfile.data.ResolvedUrl;
 import io.github.chains_project.maven_lockfile.data.VersionNumber;
@@ -86,6 +88,7 @@ public void singleDependencyCheckMustFail(MavenExecutionResult result) throws Ex
     }
 
     @MavenTest
+    @SuppressWarnings("null")
     public void pluginProject(MavenExecutionResult result) throws Exception {
         // contract: if including maven plugins the lockfile should contain these and be able to calculate checksums for
         // them. Plugin dependencies should also be resolved and recorded.
@@ -105,6 +108,29 @@ public void pluginProject(MavenExecutionResult result) throws Exception {
         assertThat(lockFile.getMavenPlugins())
                 .allMatch(
                         p -> p.getDependencies() != null && !p.getDependencies().isEmpty());
+
+        lockFile.getMavenPlugins().forEach(plugin -> {
+            plugin.getDependencies().forEach(dep -> {
+                var scope = dep.getScope();
+                if (scope == null) {
+                    fail(String.format(
+                            "scope is null for dependency %s:%s:%s",
+                            dep.getGroupId().getValue(),
+                            dep.getArtifactId().getValue(),
+                            dep.getVersion().getValue()));
+                    return;
+                }
+                // Log the offending plugin that includes the unexpected scope.
+                // Null check warnings are suppressed because the .as() method always generates such a warning.
+                assertThat(scope)
+                        .as(
+                                "Scope of plugin dependency %s:%s:%s",
+                                dep.getGroupId().getValue(),
+                                dep.getArtifactId().getValue(),
+                                dep.getVersion().getValue())
+                        .isNotEqualTo(MavenScope.TEST);
+            });
+        });
     }
 
     @MavenTest