Skip to content

Commit 3154344

Browse files
committed
🗑:wastebasket: remove buildExtensionsSimple integration test
Remove redundant buildExtensionsSimple test as buildExtensionsMultiple provides sufficient coverage for build extensions functionality. Changes: - Remove buildExtensionsSimple test directory - Remove buildExtensionsSimple test method from IntegrationTestsIT Signed-off-by: Timotej Kubas <tkubas@redhat.com>
1 parent 693af0f commit 3154344

File tree

3 files changed

+0
-96
lines changed

3 files changed

+0
-96
lines changed

maven_plugin/src/test/java/it/IntegrationTestsIT.java

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -736,55 +736,6 @@ public void freezePluginDependencies(MavenExecutionResult result) throws Excepti
736736
}
737737
}
738738

739-
@MavenTest
740-
@SuppressWarnings("null")
741-
public void buildExtensionsSimple(MavenExecutionResult result) throws Exception {
742-
// contract: if a project uses build extensions, the lockfile should contain them with checksums
743-
// and their dependencies should be resolved and recorded
744-
System.out.println("Running 'buildExtensionsSimple' integration test.");
745-
assertThat(result).isSuccessful();
746-
Path lockFilePath = findFile(result, "lockfile.json");
747-
assertThat(lockFilePath).exists();
748-
var lockFile = LockFile.readLockFile(lockFilePath);
749-
assertThat(lockFile.getMavenExtensions()).isNotEmpty();
750-
assertThat(lockFile.getMavenExtensions()).hasSize(1);
751-
752-
// Verify extension has valid checksum
753-
assertThat(lockFile.getMavenExtensions())
754-
.allMatch(v -> !v.getChecksum().isBlank()
755-
&& v.getChecksumAlgorithm().equals(lockFile.getConfig().getChecksumAlgorithm()));
756-
757-
// Verify extension artifact details
758-
var extension = lockFile.getMavenExtensions().iterator().next();
759-
assertThat(extension.getGroupId()).extracting(GroupId::getValue).isEqualTo("kr.motd.maven");
760-
assertThat(extension.getArtifactId()).extracting(ArtifactId::getValue).isEqualTo("os-maven-plugin");
761-
assertThat(extension.getVersion()).extracting(VersionNumber::getValue).isEqualTo("1.7.1");
762-
763-
// Verify extension dependencies are resolved (os-maven-plugin has dependencies)
764-
assertThat(extension.getDependencies()).isNotNull();
765-
assertThat(extension.getDependencies()).isNotEmpty();
766-
767-
// Verify all dependencies have valid scopes and TEST scope is excluded
768-
extension.getDependencies().forEach(dep -> {
769-
var scope = dep.getScope();
770-
if (scope == null) {
771-
fail(String.format(
772-
"scope is null for dependency %s:%s:%s",
773-
dep.getGroupId().getValue(),
774-
dep.getArtifactId().getValue(),
775-
dep.getVersion().getValue()));
776-
return;
777-
}
778-
assertThat(scope)
779-
.as(
780-
"Scope of extension dependency %s:%s:%s",
781-
dep.getGroupId().getValue(),
782-
dep.getArtifactId().getValue(),
783-
dep.getVersion().getValue())
784-
.isNotEqualTo(MavenScope.TEST);
785-
});
786-
}
787-
788739
@MavenTest
789740
@SuppressWarnings("null")
790741
public void buildExtensionsMultiple(MavenExecutionResult result) throws Exception {

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/buildExtensionsSimple/pom.xml

Lines changed: 0 additions & 42 deletions
This file was deleted.

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/buildExtensionsSimple/src/main/java/HelloWorld.java

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)