Skip to content

Commit d98e4c9

Browse files
authored
🚸 feat: Change default checksumMode from local to remote (#1199)
1 parent ed338e7 commit d98e4c9

File tree

29 files changed

+261
-223
lines changed

29 files changed

+261
-223
lines changed

maven_plugin/src/main/java/io/github/chains_project/maven_lockfile/AbstractLockfileMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public abstract class AbstractLockfileMojo extends AbstractMojo {
5757
@Parameter(property = "checksumAlgorithm")
5858
protected String checksumAlgorithm;
5959

60-
@Parameter(defaultValue = "local", property = "checksumMode")
60+
@Parameter(defaultValue = "remote", property = "checksumMode")
6161
protected String checksumMode;
6262

6363
@Parameter(property = "reduced")

maven_plugin/src/test/java/it/IntegrationTestsIT.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ public void singleDependencyCheckMustFail(MavenExecutionResult result) throws Ex
7777

7878
@MavenTest
7979
public void pluginProject(MavenExecutionResult result) throws Exception {
80+
// contract: if including maven plugins the lockfile should contain these and be able to calculate checksums for
81+
// them.
82+
// Note that remote does not work as the maven-lockfile plugin with SNAPSHOT version is not available on remote.
8083
assertThat(result).isSuccessful();
8184
Path lockFilePath = findFile(result, "lockfile.json");
8285
assertThat(lockFilePath).exists();

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/classifierDependency/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
</execution>
4646
</executions>
4747
<configuration>
48+
<checksumMode>local</checksumMode>
4849
</configuration>
4950
</plugin>
5051
</plugins>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/classifierDependencyCheckCorrect/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
</execution>
4545
</executions>
4646
<configuration>
47+
<checksumMode>local</checksumMode>
4748
</configuration>
4849
</plugin>
4950
</plugins>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/classifierDependencyCheckMustFail/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
</execution>
4646
</executions>
4747
<configuration>
48+
<checksumMode>local</checksumMode>
4849
</configuration>
4950
</plugin>
5051
</plugins>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/differentLockfileName/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
</execution>
3434
</executions>
3535
<configuration>
36+
<checksumMode>local</checksumMode>
3637
<lockfileName>different-lockfile-name.json</lockfileName>
3738
</configuration>
3839
</plugin>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/differentLockfileNameFreezeShouldSucceed/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
</execution>
3434
</executions>
3535
<configuration>
36+
<checksumMode>local</checksumMode>
3637
<lockfileName>different-lockfile-name.json</lockfileName>
3738
</configuration>
3839
</plugin>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/differentLockfileNameValidateShouldFail/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
</execution>
3434
</executions>
3535
<configuration>
36+
<checksumMode>local</checksumMode>
3637
<lockfileName>different-lockfile-name.json</lockfileName>
3738
</configuration>
3839
</plugin>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/differentLockfileNameValidateShouldSucceed/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
</execution>
3434
</executions>
3535
<configuration>
36+
<checksumMode>local</checksumMode>
3637
<lockfileName>different-lockfile-name.json</lockfileName>
3738
</configuration>
3839
</plugin>

maven_plugin/src/test/resources-its/it/IntegrationTestsIT/freezeJunit/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
</execution>
3434
</executions>
3535
<configuration>
36+
<checksumMode>local</checksumMode>
3637
</configuration>
3738
</plugin>
3839
</plugins>

0 commit comments

Comments
 (0)