Skip to content

✨ feat(checksum calculator): Add cache to remote checksum calculator #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LogFlames merged 3 commits into from
Jan 29, 2026
Merged

✨ feat(checksum calculator): Add cache to remote checksum calculator #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72edf46
resolve cache
LogFlames Jan 28, 2026
8804a2b
Add equals and hashCode
LogFlames Jan 28, 2026
e87ca10
check for empty classifier
LogFlames Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions .../main/java/io/github/chains_project/maven_lockfile/checksum/RemoteChecksumCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
import java.net.http.HttpResponse;
import java.security.MessageDigest;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.project.ProjectBuildingRequest;
Expand All @@ -19,6 +21,8 @@ public class RemoteChecksumCalculator extends AbstractChecksumCalculator {

private final ProjectBuildingRequest artifactBuildingRequest;
private final ProjectBuildingRequest pluginBuildingRequest;
private final Map<String, String> checksumCache = new ConcurrentHashMap<>();
private final Map<String, RepositoryInformation> resolvedCache = new ConcurrentHashMap<>();

public RemoteChecksumCalculator(
String checksumAlgorithm,
Expand All @@ -37,7 +41,22 @@ public RemoteChecksumCalculator(
this.pluginBuildingRequest = pluginBuildingRequest;
}

private String getCacheKey(Artifact artifact) {
String classifier = artifact.getClassifier();
if (classifier == null) {
classifier = "";
}
return artifact.getGroupId() + ":" + artifact.getArtifactId() + ":" + artifact.getVersion() + ":" + classifier
+ ":" + artifact.getType();
}

private Optional<String> calculateChecksumInternal(Artifact artifact, ProjectBuildingRequest buildingRequest) {
String cacheKey = getCacheKey(artifact) + ":" + checksumAlgorithm;
String cached = checksumCache.get(cacheKey);
if (cached != null) {
return cached.isEmpty() ? Optional.empty() : Optional.of(cached);
}

try {
String groupId = artifact.getGroupId().replace(".", "/");
String artifactId = artifact.getArtifactId();
Expand Down Expand Up @@ -73,7 +92,9 @@ private Optional<String> calculateChecksumInternal(Artifact artifact, ProjectBui
client.send(checksumRequest, HttpResponse.BodyHandlers.ofString());

if (checksumResponse.statusCode() >= 200 && checksumResponse.statusCode() < 300) {
return Optional.of(checksumResponse.body().strip());
String checksum = checksumResponse.body().strip();
checksumCache.put(cacheKey, checksum);
return Optional.of(checksum);
}

if (checksumResponse.statusCode() == 404) {
Expand Down Expand Up @@ -133,6 +154,7 @@ private Optional<String> calculateChecksumInternal(Artifact artifact, ProjectBui
String checksum = baseEncoding
.encode(messageDigest.digest(artifactResponse.body()))
.toLowerCase(Locale.ROOT);
checksumCache.put(cacheKey, checksum);
return Optional.of(checksum);
}
}
Expand All @@ -141,16 +163,24 @@ private Optional<String> calculateChecksumInternal(Artifact artifact, ProjectBui
.warn(String.format(
"Artifact checksum `%s.%s` not found among remote repositories.",
artifact, checksumAlgorithm));
checksumCache.put(cacheKey, "");
return Optional.empty();
} catch (Exception e) {
PluginLogManager.getLog()
.warn(String.format("Could not resolve artifact: %s", artifact.getArtifactId()), e);
checksumCache.put(cacheKey, "");
return Optional.empty();
}
}

private Optional<RepositoryInformation> getResolvedFieldInternal(
Artifact artifact, ProjectBuildingRequest buildingRequest) {
String cacheKey = getCacheKey(artifact);
RepositoryInformation cached = resolvedCache.get(cacheKey);
if (cached != null) {
return cached.equals(RepositoryInformation.Unresolved()) ? Optional.empty() : Optional.of(cached);
}

try {
String groupId = artifact.getGroupId().replace(".", "/");
String artifactId = artifact.getArtifactId();
Expand Down Expand Up @@ -184,16 +214,20 @@ private Optional<RepositoryInformation> getResolvedFieldInternal(
HttpResponse<Void> response = client.send(request, HttpResponse.BodyHandlers.discarding());

if (response.statusCode() >= 200 && response.statusCode() < 300) {
return Optional.of(
new RepositoryInformation(ResolvedUrl.of(url), RepositoryId.of(repository.getId())));
RepositoryInformation result =
new RepositoryInformation(ResolvedUrl.of(url), RepositoryId.of(repository.getId()));
resolvedCache.put(cacheKey, result);
return Optional.of(result);
}
}

PluginLogManager.getLog().warn(String.format("Artifact resolved url `%s` not found.", artifact));
resolvedCache.put(cacheKey, RepositoryInformation.Unresolved());
return Optional.empty();
} catch (Exception e) {
PluginLogManager.getLog()
.warn(String.format("Could not resolve url for artifact: %s", artifact.getArtifactId()), e);
resolvedCache.put(cacheKey, RepositoryInformation.Unresolved());
return Optional.empty();
}
}
Expand Down
16 changes: 16 additions & 0 deletions ...src/main/java/io/github/chains_project/maven_lockfile/checksum/RepositoryInformation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io.github.chains_project.maven_lockfile.data.RepositoryId;
import io.github.chains_project.maven_lockfile.data.ResolvedUrl;
import java.util.Objects;

public class RepositoryInformation {
private final ResolvedUrl resolvedUrl;
Expand Down Expand Up @@ -29,4 +30,19 @@ public ResolvedUrl getResolvedUrl() {
public RepositoryId getRepositoryId() {
return repositoryId;
}

@Override
public boolean equals(Object o) {
if (o == this) return true;
if (!(o instanceof RepositoryInformation)) {
return false;
}
RepositoryInformation other = (RepositoryInformation) o;
return Objects.equals(resolvedUrl, other.resolvedUrl) && Objects.equals(repositoryId, other.repositoryId);
}

@Override
public int hashCode() {
return Objects.hash(resolvedUrl, repositoryId);
}
}
Loading