multiple fixes after review

add missing cross-env for root package

fix attributesRestore for composed objects

use ExtendedPlaceAttributes instead of generic object in Place children classes

fix missing underscore in _journeyUuid param

fix copyright year in object registry test files

fix import at wrong place

fix wrong test description

add weights validation for junction (all other weightable classes add the weights validation, but it was missing for Junction)

move slugify to devDep (it was only used in tests)

use Promise.all for audits updates

remove testing from root

move auditLocales test to backend

remove restoreAttributes (not needed since the parsers can do the same work and we should limit these restoration to a minimum)

Author: kaligrafy

jest.config.js

@@ -1,26 +1,20 @@
 {
-  "I_M_Uuid": "Interview UUID is missing",
-  "I_M_Id": "Interview ID is missing",
-  "I_M_Response": "Interview has no response",
+  "I_M_Languages": "Interview languages are missing",
 
   "HH_I_Size": "Household size is out of range (should be between 1 and 20)",
-  "HH_M_Uuid": "Household UUID is missing",
+  "HH_M_Size": "Household size is missing",
 
   "HM_M_Geography": "Home geography is missing",
-  "HM_M_Uuid": "Home UUID is missing",
+  "HM_I_Geography": "Home geography is invalid",
 
-  "P_M_Uuid": "Person UUID is missing",
   "P_M_Age": "Person age is missing",
 
-  "J_M_Uuid": "Journey UUID is missing",
-  "J_M_StartTime": "Journey start time is missing",
+  "J_M_StartDate": "Journey start date is missing",
 
   "VP_M_Geography": "Visited place geography is missing",
-  "VP_M_Uuid": "Visited place UUID is missing",
+  "VP_I_Geography": "Visited place geography is invalid",
 
-  "T_M_Uuid": "Trip UUID is missing",
-  "T_M_StartDate": "Trip start date is missing",
+  "T_M_Segments": "Trip segments are missing",
 
-  "S_M_Uuid": "Segment UUID is missing",
   "S_M_Mode": "Segment mode is missing"
 }

locales/__tests__/AuditLocales.test.ts

@@ -1,26 +1,20 @@
 {
-  "I_M_Uuid": "Le UUID de l'entrevue est manquant",
-  "I_M_Id": "Le ID de l'entrevue est manquant",
-  "I_M_Response": "L'entrevue ne contient pas de réponse",
+  "I_M_Languages": "Les langues de l'entrevue sont manquantes",
 
   "HH_I_Size": "La taille du ménage est en dehors de la plage autorisée (devrait être entre 1 et 20)",
-  "HH_M_Uuid": "Le UUID du ménage est manquant",
+  "HH_M_Size": "La taille du ménage est manquante",
 
   "HM_M_Geography": "La géographie du domicile est manquante",
-  "HM_M_Uuid": "Le UUID du domicile est manquant",
+  "HM_I_Geography": "La géographie du domicile est invalide",
 
-  "P_M_Uuid": "Le UUID de la personne est manquant",
   "P_M_Age": "L'âge de la personne est manquant",
 
-  "J_M_Uuid": "Le UUID du séjour est manquant",
-  "J_M_StartTime": "L'heure de début du séjour est manquante",
+  "J_M_StartDate": "La date de début du séjour est manquante",
 
   "VP_M_Geography": "La géographie du lieu visité est manquante",
-  "VP_M_Uuid": "Le UUID du lieu visité est manquant",
+  "VP_I_Geography": "La géographie du lieu visité est invalide",
 
-  "T_M_Uuid": "Le UUID du déplacement est manquant",
-  "T_M_StartDate": "La date de début du déplacement est manquante",
+  "T_M_Segments": "Les segments du déplacement sont manquants",
 
-  "S_M_Uuid": "Le UUID du segment est manquant",
   "S_M_Mode": "Le mode du segment est manquant"
 }

locales/en/audits.json

@@ -38,8 +38,8 @@
         "start:debug": "yarn workspace demo_survey run start:debug",
         "start:tracing": "yarn workspace demo_survey run start:tracing",
         "start:generator": "yarn workspace demo_generator run start",
-        "test": "cross-env NODE_ENV=test jest --config=jest.config.js && yarn workspace evolution-common run test && yarn workspace evolution-backend run test && yarn workspace evolution-frontend run test && yarn workspace evolution-interviewer run test",
-        "test:unit": "cross-env NODE_ENV=test jest --config=jest.config.js && yarn workspace evolution-common run test:unit && yarn workspace evolution-backend run test:unit && yarn workspace evolution-frontend run test:unit && yarn workspace evolution-interviewer run test:unit",
+        "test": "yarn workspace evolution-common run test && yarn workspace evolution-backend run test && yarn workspace evolution-frontend run test && yarn workspace evolution-interviewer run test",
+        "test:unit": "yarn workspace evolution-common run test:unit && yarn workspace evolution-backend run test:unit && yarn workspace evolution-frontend run test:unit && yarn workspace evolution-interviewer run test:unit",
         "test:sequential": "yarn workspace evolution-common run test:sequential && yarn workspace evolution-backend run test:sequential && yarn workspace evolution-frontend run test:sequential && yarn workspace evolution-interviewer run test:sequential",
         "test:generator": "python -m pytest -s -W ignore packages/evolution-generator/src/tests/",
         "test:ui": "yarn workspace demo_survey run test:ui",

locales/fr/audits.json

@@ -44,7 +44,7 @@ router.get(
                     }
                     // Run audits on the corrected_response
                     const objectsAndAudits: SurveyObjectsWithAudits =
-                        await SurveyObjectsAndAuditsFactory.createSurveyObjectsAndAudit(interview);
+                        await SurveyObjectsAndAuditsFactory.createSurveyObjectsAndSaveAuditsToDb(interview);
 
                     // TODO Here, the response field should not make it to frontend. But make sure there are no side effect in the frontend, where the _response is used or checked.
                     const { response, corrected_response, ...rest } = interview;

package.json

@@ -7,7 +7,7 @@
 import { SurveyObjectsWithAudits } from 'evolution-common/lib/services/audits/types';
 import { ServerFieldUpdateCallback } from '../services/interviews/serverFieldUpdate';
 import { ServerValidation } from '../services/validations/serverValidation';
-import { AttributesToRestore, SurveyObjectParsers } from '../services/audits/types';
+import { SurveyObjectParsers } from '../services/audits/types';
 import {
     InterviewAttributes,
     InterviewListAttributes,
@@ -29,12 +29,6 @@ interface ProjectServerConfig {
      * individual audits. It is optional. If the survey does not require auditing, just leave blank.
      */
     auditInterview?: (attributes: InterviewAttributes) => Promise<SurveyObjectsWithAudits>;
-    /**
-     * Configuration for restoring attributes from original responses during audit workflow.
-     * This allows preserving respondent preferences that may have been overwritten during admin corrections.
-     * Optional - if not provided, no attribute restoration will occur.
-     */
-    attributesToRestore?: AttributesToRestore;
     /**
      * Configuration for parsing survey response values before object creation.
      * This allows converting string values like 'yes'/'no' to proper types like boolean