Skip to content

Commit 8bfa962

Browse files
committed
networkDesign: make the OdTripSimulationMethod's sampleRatio a percentage
1 parent f25b375 commit 8bfa962

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

locales/en/transit.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -941,8 +941,8 @@
941941
"WalkingSpeedMps": "Walking speed (m/s)",
942942
"WalkingSpeedFactor": "Walking speed factor",
943943
"WalkingSpeedFactorHelp": "Factor to multiply the walking speed. For example, a value of 0.8 will reduce walking speed by 20%, while a value of 1.2 will increase it by 20%.",
944-
"OdTripsSampleRatio": "Percentage of OD trips to include",
945-
"OdTripsSampleRatioInvalid": "Invalid percentage of OD trips to include. Must be between 0 and 1.",
944+
"OdTripsSampleRatio": "Percentage of OD trips to include (between 0 and 100)",
945+
"OdTripsSampleRatioInvalid": "Invalid percentage of OD trips to include. Must be between 0 and 100.",
946946
"fitness": {
947947
"odTripFitnessFunction": "Cost function for OD trip result",
948948
"travelTimeCost": "Travel time",

locales/fr/transit.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -941,8 +941,8 @@
941941
"WalkingSpeedMps": "Vitesse de marche (m/s)",
942942
"WalkingSpeedFactor": "Facteur de vitesse de marche",
943943
"WalkingSpeedFactorHelp": "Facteur à multiplier par la vitesse de marche. Par exemple, une valeur de 0,8 réduira la vitesse de marche de 20 %, tandis qu'une valeur de 1,2 l'augmentera de 20 %.",
944-
"OdTripsSampleRatio": "Pourcentage des trajets OD à inclure",
945-
"OdTripsSampleRatioInvalid": "Pourcentage invalide des trajets OD à inclure. Doit être compris entre 0 et 1.",
944+
"OdTripsSampleRatio": "Pourcentage des trajets OD à inclure (entre 0 et 100)",
945+
"OdTripsSampleRatioInvalid": "Pourcentage invalide des trajets OD à inclure. Doit être compris entre 0 et 100.",
946946
"fitness": {
947947
"odTripFitnessFunction": "Fonction de coût d'un résultat OD",
948948
"travelTimeCost": "Temps de parcours",

packages/transition-common/src/services/networkDesign/transit/simulationMethod/OdTripSimulationMethod.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ class SimulationOptionsDescriptor implements SimulationAlgorithmDescriptor<OdTri
136136
getOptions = () => ({
137137
sampleRatio: {
138138
i18nName: 'transit:networkDesign.simulationMethods.odTrips.OdTripsSampleRatio',
139-
type: 'number' as const,
139+
type: 'percentage' as const,
140140
validate: (value: number) => value > 0 && value <= 1,
141141
default: 1
142142
},

packages/transition-common/src/services/networkDesign/transit/simulationMethod/__tests__/OdTripSimulationMethod.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ describe('OdTripSimulationDescriptor', () => {
398398
const option = simulationOptions.sampleRatio;
399399

400400
expect(option.i18nName).toBe('transit:networkDesign.simulationMethods.odTrips.OdTripsSampleRatio');
401-
expect(option.type).toBe('number');
401+
expect(option.type).toBe('percentage');
402402
expect(option.validate).toBeInstanceOf(Function);
403403
expect(option.default).toBe(1);
404404
});

0 commit comments

Comments
 (0)