networkDesign frontend: fix update loop in simulation edit

The `csvFieldMapper` prop should not be in the dependency list of the
upload status update, otherwise it loops. If the mapper changed, the
parent is already aware, this effect just needs to listen for upload
status updates.

Author: tahini

packages/transition-frontend/src/components/forms/csv/GenericCsvImportAndMappingForm.tsx

@@ -118,7 +118,7 @@ const GenericCsvImportAndMappingForm: React.FunctionComponent<GenericCsvImportAn
             // Just uploaded, no need to upload it again
             setReadyToUpload(false);
         }
-    }, [uploadStatus.status, props.csvFieldMapper]);
+    }, [uploadStatus.status]); // csvFieldMapper should not be a dependency, even if used in the function, otherwise it loops. This effect just listens to the upload status update
 
     const csvFileFields = props.csvFieldMapper.getCsvFields();
 

packages/transition-frontend/src/components/forms/networkDesign/widgets/OptionsDescriptorWidgets.tsx

@@ -203,7 +203,7 @@ const OptionsEditComponent: React.FunctionComponent<OptionsEditComponentProps<an
     props: OptionsEditComponentProps<any>
 ) => {
     const { t } = useTranslation(['transit', 'main']);
-    const options = props.optionsDescriptor.getOptions();
+    const options = React.useMemo(() => props.optionsDescriptor.getOptions(), [props.optionsDescriptor]);
     const optionWidgets = Object.keys(options).map((optionName) => {
         const option = options[optionName];
         return (