Skip to content

Commit 02a471a

Browse files
Address CR comments
1 parent d3222bd commit 02a471a

File tree

9 files changed

+33
-33
lines changed

9 files changed

+33
-33
lines changed

bin/NativeTests/CodexTests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
44
//-------------------------------------------------------------------------------------------------------
55
#include "stdafx.h"
6-
#pragma warning(disable:26434)
7-
#pragma warning(disable:26439)
8-
#pragma warning(disable:26451)
9-
#pragma warning(disable:26495)
6+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
7+
#pragma warning(disable:26439) // Implicit noexcept
8+
#pragma warning(disable:26451) // Arithmetic overflow
9+
#pragma warning(disable:26495) // Uninitialized member variable
1010
#include "catch.hpp"
1111
#include <process.h>
1212
#include "Codex\Utf8Codex.h"

bin/NativeTests/FunctionExecutionTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
44
//-------------------------------------------------------------------------------------------------------
55
#include "stdafx.h"
6-
#pragma warning(disable:26434)
7-
#pragma warning(disable:26439)
8-
#pragma warning(disable:26451)
9-
#pragma warning(disable:26495)
6+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
7+
#pragma warning(disable:26439) // Implicit noexcept
8+
#pragma warning(disable:26451) // Arithmetic overflow
9+
#pragma warning(disable:26495) // Uninitialized member variable
1010
#include "catch.hpp"
1111
#include "FunctionExecutionTest.h"
1212

bin/NativeTests/JsDiagApiTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
//-------------------------------------------------------------------------------------------------------
55

66
#include "stdafx.h"
7-
#pragma warning(disable:26434)
8-
#pragma warning(disable:26439)
9-
#pragma warning(disable:26451)
10-
#pragma warning(disable:26495)
7+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
8+
#pragma warning(disable:26439) // Implicit noexcept
9+
#pragma warning(disable:26451) // Arithmetic overflow
10+
#pragma warning(disable:26495) // Uninitialized member variable
1111
#include "catch.hpp"
1212
#include <process.h>
1313

bin/NativeTests/JsRTApiTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
44
//-------------------------------------------------------------------------------------------------------
55
#include "stdafx.h"
6-
#pragma warning(disable:26434)
7-
#pragma warning(disable:26439)
8-
#pragma warning(disable:26451)
9-
#pragma warning(disable:26495)
6+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
7+
#pragma warning(disable:26439) // Implicit noexcept
8+
#pragma warning(disable:26451) // Arithmetic overflow
9+
#pragma warning(disable:26495) // Uninitialized member variable
1010
#include "catch.hpp"
1111
#include <array>
1212
#include <process.h>

bin/NativeTests/MemoryPolicyTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
44
//-------------------------------------------------------------------------------------------------------
55
#include "stdafx.h"
6-
#pragma warning(disable:26434)
7-
#pragma warning(disable:26439)
8-
#pragma warning(disable:26451)
9-
#pragma warning(disable:26495)
6+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
7+
#pragma warning(disable:26439) // Implicit noexcept
8+
#pragma warning(disable:26451) // Arithmetic overflow
9+
#pragma warning(disable:26495) // Uninitialized member variable
1010
#include "catch.hpp"
1111

1212
#pragma warning(disable:6387) // suppressing preFAST which raises warning for passing null to the JsRT APIs

bin/NativeTests/NativeTests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
// conversion from 'int' to 'char', possible loss of data
1010
#pragma warning(disable:4242)
1111
#pragma warning(disable:4244)
12-
#pragma warning(disable:26434)
13-
#pragma warning(disable:26439)
14-
#pragma warning(disable:26451)
15-
#pragma warning(disable:26495)
12+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
13+
#pragma warning(disable:26439) // Implicit noexcept
14+
#pragma warning(disable:26451) // Arithmetic overflow
15+
#pragma warning(disable:26495) // Uninitialized member variable
1616
#include "catch.hpp"
1717
#pragma warning(pop)
1818

bin/NativeTests/ThreadServiceTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
//-------------------------------------------------------------------------------------------------------
55

66
#include "stdafx.h"
7-
#pragma warning(disable:26434)
8-
#pragma warning(disable:26439)
9-
#pragma warning(disable:26451)
10-
#pragma warning(disable:26495)
7+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
8+
#pragma warning(disable:26439) // Implicit noexcept
9+
#pragma warning(disable:26451) // Arithmetic overflow
10+
#pragma warning(disable:26495) // Uninitialized member variable
1111
#include "catch.hpp"
1212

1313
#pragma warning(disable:6387) // suppressing preFAST which raises warning for passing null to the JsRT APIs

bin/NativeTests/UnicodeTextTests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
//-------------------------------------------------------------------------------------------------------
55

66
#include "stdafx.h"
7-
#pragma warning(disable:26434)
8-
#pragma warning(disable:26439)
9-
#pragma warning(disable:26451)
10-
#pragma warning(disable:26495)
7+
#pragma warning(disable:26434) // Function definition hides non-virtual function in base class
8+
#pragma warning(disable:26439) // Implicit noexcept
9+
#pragma warning(disable:26451) // Arithmetic overflow
10+
#pragma warning(disable:26495) // Uninitialized member variable
1111
#include "catch.hpp"
1212

1313
namespace UnicodeTextTest

lib/Backend/Lower.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21156,7 +21156,7 @@ Lowerer::GenerateArgOutForStackArgs(IR::Instr* callInstr, IR::Instr* stackArgsIn
2115621156

2115721157

2115821158
#if defined(_M_IX86)
21159-
// We get a compilation error on x86 due to assiging a negative to a uint
21159+
// We get a compilation error on x86 due to assigning a negative to a uint
2116021160
// TODO: don't even define this function on x86 - we Assert(false) anyway there.
2116121161
// Alternatively, don't define when INT_ARG_REG_COUNT - 4 < 0
2116221162
AssertOrFailFast(false);

0 commit comments

Comments
 (0)