Skip to content

Commit 0458adf

Browse files
committed
PR feedback
- removed no longer necessary `IsProjectionArrayBuffer` - better comment for the `AllocPolicyLimit` flag
1 parent 38ffa70 commit 0458adf

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

lib/Common/ConfigFlagsList.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1431,7 +1431,7 @@ FLAGNR(Boolean, RecyclerVerifyMark , "verify concurrent gc", false)
14311431
#endif
14321432
FLAGR (Number, LowMemoryCap , "Memory cap indicating a low-memory process", DEFAULT_CONFIG_LowMemoryCap)
14331433
FLAGNR(Number, NewPagesCapDuringBGSweeping, "New pages count allowed to be allocated during background sweeping", DEFAULT_CONFIG_NewPagesCapDuringBGSweeping)
1434-
FLAGR (Number, AllocPolicyLimit , "Memory allocation policy limit in MB (default: -1).", DEFAULT_CONFIG_AllocationPolicyLimit)
1434+
FLAGR (Number, AllocPolicyLimit , "Memory allocation policy limit in MB (default: -1, which means no allocation policy limit).", DEFAULT_CONFIG_AllocationPolicyLimit)
14351435
#ifdef RUNTIME_DATA_COLLECTION
14361436
FLAGNR(String, RuntimeDataOutputFile, "Filename to write the dynamic profile info", nullptr)
14371437
#endif

lib/Runtime/Library/ArrayBuffer.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ namespace Js
8686
virtual bool IsArrayBuffer() = 0;
8787
virtual bool IsSharedArrayBuffer() = 0;
8888
virtual bool IsWebAssemblyArrayBuffer() { return false; }
89-
virtual bool IsProjectionArrayBuffer() { return false; }
9089
virtual ArrayBuffer * GetAsArrayBuffer() = 0;
9190
virtual SharedArrayBuffer * GetAsSharedArrayBuffer() { return nullptr; }
9291
virtual void AddParent(ArrayBufferParent* parent) { }
@@ -327,7 +326,6 @@ namespace Js
327326
static ProjectionArrayBuffer* Create(byte* buffer, DECLSPEC_GUARD_OVERFLOW uint32 length, DynamicType * type);
328327
virtual void Dispose(bool isShutdown) override;
329328
virtual void Finalize(bool isShutdown) override;
330-
virtual bool IsProjectionArrayBuffer() override { return true; }
331329
private:
332330
ProjectionArrayBuffer(uint32 length, DynamicType * type);
333331
ProjectionArrayBuffer(byte* buffer, uint32 length, DynamicType * type);

0 commit comments

Comments
 (0)