[MERGE #5557 @meg-gupta] OS#17531342 : Fix provability check on BrOnObject

Meghana Gupta · Meghana Gupta · commit 0625d4a33723 · 2018-07-30T14:34:50.000-07:00
Merge pull request #5557 from meg-gupta:bronobjectbug BrOnObject returns true for all non primitives in the interpreter, fix the case for BrOnObject while checking for provability to reflect the same.
diff --git a/lib/Backend/GlobOpt.cpp b/lib/Backend/GlobOpt.cpp
@@ -6791,7 +6791,7 @@ GlobOpt::CanProveConditionalBranch(IR::Instr *instr, Value *src1Val, Value *src2
         {
             return false;
         }
-        *result = src1ValueInfo->IsObject();
+        *result = !src1ValueInfo->IsPrimitive();
         break;
     }
     default:

Original file line number	Diff line number	Diff line change
`@@ -6791,7 +6791,7 @@ GlobOpt::CanProveConditionalBranch(IR::Instr instr, Value src1Val, Value *src2`
`6791`	`6791`	`{`
`6792`	`6792`	`return false;`
`6793`	`6793`	`}`
`6794`		`- *result = src1ValueInfo->IsObject();`
	`6794`	`+ *result = !src1ValueInfo->IsPrimitive();`
`6795`	`6795`	`break;`
`6796`	`6796`	`}`
`6797`	`6797`	`default:`