Skip to content

Commit 0b023ba

Browse files
rhuanjlsigatrev
authored andcommitted
Enable JsBuiltIns on Lite and no_icu builds
1 parent 819ebeb commit 0b023ba

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

lib/Common/CommonDefines.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,10 @@
132132
// Language features
133133
#if !defined(CHAKRACORE_LITE) && (defined(_WIN32) || defined(INTL_ICU))
134134
#define ENABLE_INTL_OBJECT // Intl support
135-
#define ENABLE_JS_BUILTINS // Built In functions support
136135
#endif
137136

137+
#define ENABLE_JS_BUILTINS // Built In functions support
138+
138139
#if defined(_WIN32) && !defined(HAS_ICU)
139140
#define INTL_WINGLOB 1
140141
#endif

test/Array/rlexe.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
<default>
1111
<files>array_flat.js</files>
1212
<compile-flags>-args summary -endargs</compile-flags>
13-
<!-- Lite builds don't enable JsBuiltIns hence the array flat methods won't work on them - Intl flag identifies these builds-->
14-
<tags>Intl</tags>
1513
</default>
1614
</test>
1715
<test>

test/Miscellaneous/rlexe.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<files>../../lib/Runtime/Library/JsBuiltIn/JsBuiltIn.js</files>
2525
<baseline>../../lib/Runtime/Library/JsBuiltIn/JsBuiltIn.js.nojit.bc.32b.h</baseline>
2626
<compile-flags>-GenerateLibraryByteCodeHeader -JsBuiltIn -LdChakraLib</compile-flags>
27-
<tags>exclude_jshost,exclude_x64,require_disable_jit,exclude_lite,exclude_forceserialized</tags>
27+
<tags>exclude_jshost,exclude_x64,require_disable_jit,exclude_forceserialized</tags>
2828
<eol-normalization />
2929
</default>
3030
</test>
@@ -33,7 +33,7 @@
3333
<files>../../lib/Runtime/Library/JsBuiltIn/JsBuiltIn.js</files>
3434
<baseline>../../lib/Runtime/Library/JsBuiltIn/JsBuiltIn.js.nojit.bc.64b.h</baseline>
3535
<compile-flags>-GenerateLibraryByteCodeHeader -JsBuiltIn -LdChakraLib</compile-flags>
36-
<tags>exclude_jshost,exclude_x86,require_disable_jit,exclude_lite,exclude_forceserialized</tags>
36+
<tags>exclude_jshost,exclude_x86,require_disable_jit,exclude_forceserialized</tags>
3737
<eol-normalization />
3838
</default>
3939
</test>

0 commit comments

Comments
 (0)