[MERGE #5276 @irinayat-MS] Remove unused CloseSources and related methods

Merge pull request #5276 from irinayat-MS:unused_CloneSources

Author: Irina Yatsenko

lib/Jsrt/JsrtSourceHolder.h

@@ -103,11 +103,6 @@ namespace Js
                         || memcmp(this->GetSource(_u("Equal Comparison")), other->GetSource(_u("Equal Comparison")), this->GetByteLength(_u("Equal Comparison"))) == 0));
         }
 
-        virtual ISourceHolder* Clone(ScriptContext *scriptContext) override
-        {
-            return RecyclerNewFinalized(scriptContext->GetRecycler(), JsrtSourceHolder, this->scriptLoadCallback, this->scriptUnloadCallback, this->sourceContext);
-        }
-
         virtual hash_t GetHashCode() override
         {
             LPCUTF8 source = GetSource(_u("Hash Code Calculation"));

lib/Runtime/Base/ScriptContext.cpp

@@ -2672,25 +2672,6 @@ namespace Js
     }
 #endif
 
-    bool ScriptContext::SaveSourceCopy(Utf8SourceInfo* const sourceInfo, int cchLength, bool isCesu8, uint * index)
-    {
-        HRESULT hr = S_OK;
-        BEGIN_TRANSLATE_OOM_TO_HRESULT
-        {
-            *index = this->SaveSourceCopy(sourceInfo, cchLength, isCesu8);
-        }
-        END_TRANSLATE_OOM_TO_HRESULT(hr);
-        return hr == S_OK;
-    }
-
-    uint ScriptContext::SaveSourceCopy(Utf8SourceInfo* sourceInfo, int cchLength, bool isCesu8)
-    {
-        Utf8SourceInfo* newSource = Utf8SourceInfo::Clone(this, sourceInfo);
-
-        return SaveSourceNoCopy(newSource, cchLength, isCesu8);
-    }
-
-
     uint ScriptContext::SaveSourceNoCopy(Utf8SourceInfo* sourceInfo, int cchLength, bool isCesu8)
     {
         Assert(sourceInfo->GetScriptContext() == this);
@@ -2712,23 +2693,6 @@ namespace Js
         }
     }
 
-    void ScriptContext::CloneSources(ScriptContext* sourceContext)
-    {
-        sourceContext->sourceList->Map([=](int index, RecyclerWeakReference<Utf8SourceInfo>* sourceInfo)
-        {
-            Utf8SourceInfo* info = sourceInfo->Get();
-            if (info)
-            {
-                CloneSource(info);
-            }
-        });
-    }
-
-    uint ScriptContext::CloneSource(Utf8SourceInfo* info)
-    {
-        return this->SaveSourceCopy(info, info->GetCchLength(), info->GetIsCesu8());
-    }
-
     Utf8SourceInfo* ScriptContext::GetSource(uint index)
     {
         Assert(this->sourceList->IsItemValid(index)); // This assert should be a subset of info != null- if info was null, in the last collect, we'd have invalidated the item

lib/Runtime/Base/ScriptContext.h

@@ -1439,12 +1439,8 @@ namespace Js
         BOOL IsNativeAddress(void * codeAddr);
 #endif
 
-        uint SaveSourceCopy(Utf8SourceInfo* sourceInfo, int cchLength, bool isCesu8);
-        bool SaveSourceCopy(Utf8SourceInfo* const sourceInfo, int cchLength, bool isCesu8, uint * index);
-
         uint SaveSourceNoCopy(Utf8SourceInfo* sourceInfo, int cchLength, bool isCesu8);
 
-        void CloneSources(ScriptContext* sourceContext);
         Utf8SourceInfo* GetSource(uint sourceIndex);
 
         uint SourceCount() const { return (uint)sourceList->Count(); }
@@ -1536,8 +1532,6 @@ namespace Js
 
         void FreeFunctionEntryPoint(Js::JavascriptMethod codeAddress, Js::JavascriptMethod thunkAddress);
 
-    private:
-        uint CloneSource(Utf8SourceInfo* info);
     public:
         void RegisterProtoInlineCache(InlineCache *pCache, PropertyId propId);
         void InvalidateProtoCaches(const PropertyId propertyId);

lib/Runtime/Base/SourceHolder.cpp

@@ -8,16 +8,4 @@ namespace Js
 {
     LPCUTF8 const ISourceHolder::emptyString = (LPCUTF8)"\0";
     SimpleSourceHolder const ISourceHolder::emptySourceHolder(NO_WRITE_BARRIER_TAG(emptyString), 0, true);
-
-    ISourceHolder* SimpleSourceHolder::Clone(ScriptContext* scriptContext)
-    {
-        if(this == ISourceHolder::GetEmptySourceHolder())
-        {
-            return this;
-        }
-
-        utf8char_t * newUtf8String = RecyclerNewArrayLeaf(scriptContext->GetRecycler(), utf8char_t, byteLength + 1);
-        js_memcpy_s(newUtf8String, byteLength + 1, this->source, byteLength + 1);
-        return RecyclerNew(scriptContext->GetRecycler(), SimpleSourceHolder, newUtf8String, byteLength);
-    }
 }

lib/Runtime/Base/SourceHolder.h

@@ -20,7 +20,6 @@ namespace Js
 
         virtual LPCUTF8 GetSource(const char16* reasonString) = 0;
         virtual size_t GetByteLength(const char16* reasonString) = 0;
-        virtual ISourceHolder* Clone(ScriptContext* scriptContext) = 0;
         virtual bool Equals(ISourceHolder* other) = 0;
         virtual hash_t GetHashCode() = 0;
         virtual bool IsEmpty() = 0;
@@ -56,7 +55,6 @@ namespace Js
         }
 
         virtual size_t GetByteLength(const char16* reasonString) override { return byteLength; }
-        virtual ISourceHolder* Clone(ScriptContext* scriptContext) override;
 
         virtual bool Equals(ISourceHolder* other) override
         {

lib/Runtime/Base/Utf8SourceInfo.cpp

@@ -254,29 +254,6 @@ namespace Js
         return NewWithHolder(scriptContext, sourceHolder, length, srcInfo, isLibraryCode, scriptSource);
     }
 
-
-    Utf8SourceInfo*
-    Utf8SourceInfo::Clone(ScriptContext* scriptContext, const Utf8SourceInfo* sourceInfo)
-    {
-        Utf8SourceInfo* newSourceInfo = Utf8SourceInfo::NewWithHolder(scriptContext,
-            sourceInfo->GetSourceHolder()->Clone(scriptContext), sourceInfo->m_cchLength,
-            SRCINFO::Copy(scriptContext->GetRecycler(), sourceInfo->GetSrcInfo()),
-            sourceInfo->m_isLibraryCode);
-        newSourceInfo->m_isXDomain = sourceInfo->m_isXDomain;
-        newSourceInfo->m_isXDomainString = sourceInfo->m_isXDomainString;
-        newSourceInfo->m_isLibraryCode = sourceInfo->m_isLibraryCode;
-        newSourceInfo->SetIsCesu8(sourceInfo->GetIsCesu8());
-        newSourceInfo->m_lineOffsetCache = sourceInfo->m_lineOffsetCache;
-
-#ifdef ENABLE_SCRIPT_DEBUGGING
-        if (scriptContext->IsScriptContextInDebugMode() && !newSourceInfo->GetIsLibraryCode())
-        {
-            newSourceInfo->SetInDebugMode(true);
-        }
-#endif
-        return newSourceInfo;
-    }
-
     HRESULT Utf8SourceInfo::EnsureLineOffsetCacheNoThrow()
     {
         HRESULT hr = S_OK;

lib/Runtime/Base/Utf8SourceInfo.h

@@ -299,7 +299,6 @@ namespace Js
         static Utf8SourceInfo* NewWithNoCopy(ScriptContext* scriptContext,
             LPCUTF8 utf8String, int32 length, size_t numBytes,
             SRCINFO const* srcInfo, bool isLibraryCode, Js::Var scriptSource = nullptr);
-        static Utf8SourceInfo* Clone(ScriptContext* scriptContext, const Utf8SourceInfo* sourceinfo);
 
         ScriptContext * GetScriptContext() const
         {