PR feedback

VSadov · VSadov · commit 1348adeda2cf · 2018-07-09T12:06:55.000-07:00
diff --git a/lib/Runtime/Base/CallInfo.h b/lib/Runtime/Base/CallInfo.h
@@ -93,6 +93,10 @@ namespace Js
 
         static bool HasExtraArg(CallFlags flags)
         {
+            // Generally HasNewTarget should not be true if CallFlags_ExtraArg is not set.
+            Assert(!CallInfo::HasNewTarget(flags) || flags & CallFlags_ExtraArg);
+
+            // we will still check HasNewTarget to be safe in case if above invariant does not hold.
             return (flags & CallFlags_ExtraArg) || CallInfo::HasNewTarget(flags);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,10 @@ namespace Js`
`93`	`93`
`94`	`94`	`static bool HasExtraArg(CallFlags flags)`
`95`	`95`	`{`
	`96`	`+ // Generally HasNewTarget should not be true if CallFlags_ExtraArg is not set.`
	`97`	`+ Assert(!CallInfo::HasNewTarget(flags) \|\| flags & CallFlags_ExtraArg);`
	`98`	`+`
	`99`	`+ // we will still check HasNewTarget to be safe in case if above invariant does not hold.`
`96`	`100`	`return (flags & CallFlags_ExtraArg) \|\| CallInfo::HasNewTarget(flags);`
`97`	`101`	`}`
`98`	`102`