Skip to content

Commit 1b1452a

Browse files
committed
Add back properties to EngineInterface that were mistakenly removed
1 parent ffe7c01 commit 1b1452a

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/Runtime/Library/EngineInterfaceObjectBuiltIns.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ GlobalBuiltInConstructor(Number)
5050
GlobalBuiltInConstructor(RegExp)
5151
GlobalBuiltInConstructor(String)
5252
GlobalBuiltInConstructor(Date)
53-
GlobalBuiltInConstructor(Error) // TODO(jahorto): consider deleting (all errors should go through builtInRaise*)
53+
GlobalBuiltInConstructor(Error) // TODO(jahorto): consider deleting (currently used by WinRT Promises)
5454
GlobalBuiltInConstructor(Map) // TODO(jahorto): consider deleting (when do we need a Map over an object?)
5555
GlobalBuiltInConstructor(Symbol)
5656

@@ -66,6 +66,8 @@ GlobalBuiltIn(JavascriptObject, GetOwnPropertyNames)
6666
GlobalBuiltIn(JavascriptObject, HasOwnProperty)
6767
GlobalBuiltIn(JavascriptObject, Keys)
6868
GlobalBuiltIn(JavascriptObject, Create)
69+
GlobalBuiltIn(JavascriptObject, GetOwnPropertyDescriptor)
70+
GlobalBuiltIn(JavascriptObject, PreventExtensions)
6971

7072
GlobalBuiltIn(JavascriptArray, Push) // TODO(jahorto): consider deleting (trivially implementable in JS)
7173
GlobalBuiltIn(JavascriptArray, Join)
@@ -90,7 +92,7 @@ GlobalBuiltIn(JavascriptString, IndexOf)
9092

9193
GlobalBuiltIn(GlobalObject, IsFinite) // TODO(jahorto): consider switching to Number.isFinite
9294
GlobalBuiltIn(GlobalObject, IsNaN) // TODO(jahorto): consider switching to Number.isNaN
93-
GlobalBuiltIn(GlobalObject, Eval) // TODO(jahorto): consider deleting (should any builtins be using eval()?)
95+
GlobalBuiltIn(GlobalObject, Eval) // TODO(jahorto): consider deleting (currently used by WinRT Promises)
9496

9597
BuiltInRaiseException(TypeError, NeedObject)
9698
BuiltInRaiseException2(TypeError, ObjectIsAlreadyInitialized)

0 commit comments

Comments
 (0)