CR suggestion

Meghana Gupta · Meghana Gupta · commit 21f2d1a04ca1 · 2018-05-16T22:26:09.000-07:00
diff --git a/lib/Backend/FlowGraph.cpp b/lib/Backend/FlowGraph.cpp
@@ -4649,13 +4649,12 @@ BasicBlock::CheckLegalityAndFoldPathDepBranches(GlobOpt* globOpt)
         else if (instr->GetSrc1()->IsIntConstOpnd())
         {
             Value **localValue = localSymToValueMap->FindOrInsertNew(instr->GetDst()->GetSym());
-            *localValue = globOpt->NewValue(IntConstantValueInfo::New(globOpt->alloc, instr->GetSrc1()->AsIntConstOpnd()->AsInt32()));
+            *localValue = globOpt->GetIntConstantValue(instr->GetSrc1()->AsIntConstOpnd()->AsInt32(), instr);
         }
         else if (instr->GetSrc1()->IsInt64ConstOpnd())
         {
             Value **localValue = localSymToValueMap->FindOrInsertNew(instr->GetDst()->GetSym());
-            int64 intValue = instr->GetSrc1()->AsInt64ConstOpnd()->GetValue();
-            *localValue = globOpt->NewValue(Int64ConstantValueInfo::New(globOpt->alloc, intValue));
+            *localValue = globOpt->GetIntConstantValue(instr->GetSrc1()->AsInt64ConstOpnd()->GetValue(), instr);
         }
         else
         {

Original file line number	Diff line number	Diff line change
`@@ -4649,13 +4649,12 @@ BasicBlock::CheckLegalityAndFoldPathDepBranches(GlobOpt* globOpt)`
`4649`	`4649`	`else if (instr->GetSrc1()->IsIntConstOpnd())`
`4650`	`4650`	`{`
`4651`	`4651`	`Value **localValue = localSymToValueMap->FindOrInsertNew(instr->GetDst()->GetSym());`
`4652`		`- *localValue = globOpt->NewValue(IntConstantValueInfo::New(globOpt->alloc, instr->GetSrc1()->AsIntConstOpnd()->AsInt32()));`
	`4652`	`+ *localValue = globOpt->GetIntConstantValue(instr->GetSrc1()->AsIntConstOpnd()->AsInt32(), instr);`
`4653`	`4653`	`}`
`4654`	`4654`	`else if (instr->GetSrc1()->IsInt64ConstOpnd())`
`4655`	`4655`	`{`
`4656`	`4656`	`Value **localValue = localSymToValueMap->FindOrInsertNew(instr->GetDst()->GetSym());`
`4657`		`- int64 intValue = instr->GetSrc1()->AsInt64ConstOpnd()->GetValue();`
`4658`		`- *localValue = globOpt->NewValue(Int64ConstantValueInfo::New(globOpt->alloc, intValue));`
	`4657`	`+ *localValue = globOpt->GetIntConstantValue(instr->GetSrc1()->AsInt64ConstOpnd()->GetValue(), instr);`
`4659`	`4658`	`}`
`4660`	`4659`	`else`
`4661`	`4660`	`{`