[CVE-2019-1131] Chakra Type confusion

boingoing · wyrichte · commit 242c59ea40c0 · 2019-08-13T08:48:38.000-07:00
diff --git a/lib/Parser/Parse.cpp b/lib/Parser/Parse.cpp
@@ -4664,10 +4664,7 @@ ParseNodePtr Parser::ParseMemberList(LPCOLESTR pNameHint, uint32* pNameHintLengt
                     }
                 }
 
-                if (buildAST)
-                {
-                    CheckArgumentsUse(pidHint, GetCurrentFunctionNode());
-                }
+                CheckArgumentsUse(pidHint, GetCurrentFunctionNode());
 
                 bool couldBeObjectPattern = !isObjectPattern && m_token.tk == tkAsg;
                 // Saving the current state as we may change the isObjectPattern down below.

Original file line number	Diff line number	Diff line change
`@@ -4664,10 +4664,7 @@ ParseNodePtr Parser::ParseMemberList(LPCOLESTR pNameHint, uint32* pNameHintLengt`
`4664`	`4664`	`}`
`4665`	`4665`	`}`
`4666`	`4666`
`4667`		`- if (buildAST)`
`4668`		`- {`
`4669`		`- CheckArgumentsUse(pidHint, GetCurrentFunctionNode());`
`4670`		`- }`
	`4667`	`+ CheckArgumentsUse(pidHint, GetCurrentFunctionNode());`
`4671`	`4668`
`4672`	`4669`	`bool couldBeObjectPattern = !isObjectPattern && m_token.tk == tkAsg;`
`4673`	`4670`	`// Saving the current state as we may change the isObjectPattern down below.`