[MERGE #5565 @mcduke] Fix enumeration of proxy properties containing null characters

Merge pull request #5565 from mcduke:master

This fixes #5492.

Author: sethbrenith

lib/Runtime/Library/JavascriptProxy.cpp

@@ -987,7 +987,7 @@ namespace Js
 
         struct ProxyOwnkeysEnumerator : public JavascriptEnumerator
         {
-            typedef JsUtil::BaseHashSet<const char16*, Recycler> VisitedNamesHashSet;
+            typedef JsUtil::BaseHashSet<JsUtil::CharacterBuffer<WCHAR>, Recycler> VisitedNamesHashSet;
             Field(VisitedNamesHashSet*) visited;
             Field(JavascriptArray*) trapResult;
             Field(JavascriptProxy*) proxy;
@@ -1029,10 +1029,11 @@ namespace Js
                             // let desc = Reflect.getOwnPropertyDescriptor(obj, key);
                             Js::PropertyDescriptor desc;
                             BOOL ret = JavascriptOperators::GetOwnPropertyDescriptor(proxy, propertyName, scriptContext, &desc);
+                            const JsUtil::CharacterBuffer<WCHAR> propertyString(propertyName->GetString(), propertyName->GetLength());
                             // if (desc && !visited.has(key)) {
-                            if (ret && !visited->Contains(propertyName->GetSz()))
+                            if (ret && !visited->Contains(propertyString))
                             {
-                                visited->Add(propertyName->GetSz());
+                                visited->Add(propertyString);
                                 // if (desc.enumerable) yield key;
                                 if (desc.IsEnumerable())
                                 {

test/Lib/proxyenum.baseline

@@ -0,0 +1,2 @@
+hi
+hello

test/Lib/proxyenum.js

@@ -0,0 +1,9 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+// https://github.com/Microsoft/ChakraCore/issues/5492
+
+const blah = {"\0":"hi","\0\0":"hello"};
+for (var i in new Proxy(blah, {})) console.log(blah[i]);

test/Lib/rlexe.xml

@@ -60,6 +60,12 @@
       <baseline />
     </default>
   </test>
+  <test>
+    <default>
+      <files>proxyenum.js</files>
+      <baseline>proxyenum.baseline</baseline>
+    </default>
+  </test>
   <!--
 Re-enable after 190575 is fixed
 <test>