Skip to content

Commit 2f4fcc8

Browse files
committed
Rename more CurrentMemory to MemorySize and fix unittest
1 parent 542c44e commit 2f4fcc8

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

lib/Backend/IRBuilderAsmJs.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1909,7 +1909,7 @@ IRBuilderAsmJs::BuildAsmReg1(Js::OpCodeAsmJs newOpcode, uint32 offset)
19091909
void
19101910
IRBuilderAsmJs::BuildAsmReg1(Js::OpCodeAsmJs newOpcode, uint32 offset, Js::RegSlot dstReg)
19111911
{
1912-
Assert(newOpcode == Js::OpCodeAsmJs::CurrentMemory_Int);
1912+
Assert(newOpcode == Js::OpCodeAsmJs::MemorySize_Int);
19131913
Js::RegSlot dstRegSlot = GetRegSlotFromIntReg(dstReg);
19141914
IR::RegOpnd * dstOpnd = BuildDstOpnd(dstRegSlot, TyInt32);
19151915
IR::IntConstOpnd* constZero = IR::IntConstOpnd::New(0, TyInt32, m_func);

lib/Runtime/ByteCode/OpCodesAsmJs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ MACRO_EXTEND_WMS( Trunc_Db , Double2 , None
302302
MACRO_EXTEND_WMS( Trunc_Flt , Float2 , None )
303303
MACRO_EXTEND_WMS( Nearest_Db , Double2 , None )
304304
MACRO_EXTEND_WMS( Nearest_Flt , Float2 , None )
305-
MACRO_EXTEND_WMS( CurrentMemory_Int , AsmReg1 , None )
305+
MACRO_EXTEND_WMS( MemorySize_Int , AsmReg1 , None )
306306
MACRO_EXTEND_WMS( GrowMemory , Int2 , None )
307307
MACRO_EXTEND ( Unreachable_Void , Empty , OpNoFallThrough )
308308
MACRO_EXTEND_WMS( Conv_Check_DTI , Int1Double1 , None )

lib/Runtime/Language/InterpreterHandlerAsmJs.inl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ EXDEF2_WMS( F1toF1Mem , Trunc_Flt , Wasm::WasmMath::Trunc<float>
256256
EXDEF2_WMS( F1toF1Mem , Nearest_Flt , Wasm::WasmMath::Nearest<float> )
257257
EXDEF2_WMS( D1toD1Mem , Trunc_Db , Wasm::WasmMath::Trunc<double> )
258258
EXDEF2_WMS( D1toD1Mem , Nearest_Db , Wasm::WasmMath::Nearest<double> )
259-
EXDEF2_WMS( VtoI1Mem , CurrentMemory_Int, OP_GetMemorySize )
259+
EXDEF2_WMS( VtoI1Mem , MemorySize_Int , OP_GetMemorySize )
260260
EXDEF2_WMS( I1toI1Mem , GrowMemory , OP_GrowMemory )
261261
EXDEF2 ( EMPTYASMJS , Unreachable_Void , OP_Unreachable )
262262
EXDEF2_WMS( D1toI1Ctx , Conv_Check_DTI , Wasm::WasmMath::F64ToI32<false /* saturating */> )

lib/WasmReader/WasmBinaryOpCodes.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ WASM_MEMSTORE_OPCODE(I64StoreMem8, 0x3c, L_IL, true, Js::ArrayBufferView::TYPE_
169169
WASM_MEMSTORE_OPCODE(I64StoreMem16, 0x3d, L_IL, true, Js::ArrayBufferView::TYPE_INT16_TO_INT64, "i64.store16")
170170
WASM_MEMSTORE_OPCODE(I64StoreMem32, 0x3e, L_IL, true, Js::ArrayBufferView::TYPE_INT32_TO_INT64, "i64.store32")
171171

172-
WASM_MISC_OPCODE(CurrentMemory, 0x3f, I_I, true, "current_memory")
173-
WASM_MISC_OPCODE(GrowMemory, 0x40, I_I, true, "grow_memory")
172+
WASM_MISC_OPCODE(MemorySize, 0x3f, I_I, true, "memory.size")
173+
WASM_MISC_OPCODE(MemoryGrow, 0x40, I_I, true, "memory.grow")
174174

175175
// Constants
176176
WASM_MISC_OPCODE(I32Const, 0x41, Limit, true, "i32.const")

lib/WasmReader/WasmBinaryReader.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -437,16 +437,16 @@ WasmOp WasmBinaryReader::ReadExpr()
437437
break;
438438
case wbNop:
439439
break;
440-
case wbCurrentMemory:
441-
case wbGrowMemory:
440+
case wbMemorySize:
441+
case wbMemoryGrow:
442442
{
443443
// Reserved value currently unused
444444
uint8 reserved = ReadConst<uint8>();
445445
if (reserved != 0)
446446
{
447-
ThrowDecodingError(op == wbCurrentMemory
448-
? _u("current_memory reserved value must be 0")
449-
: _u("grow_memory reserved value must be 0")
447+
ThrowDecodingError(op == wbMemorySize
448+
? _u("memory.size reserved value must be 0")
449+
: _u("memory.grow reserved value must be 0")
450450
);
451451
}
452452
break;

lib/WasmReader/WasmByteCodeGenerator.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -770,15 +770,15 @@ void WasmBytecodeGenerator::EmitExpr(WasmOp op)
770770
break;
771771
case wbNop:
772772
return;
773-
case wbCurrentMemory:
773+
case wbMemorySize:
774774
{
775775
SetUsesMemory(0);
776776
Js::RegSlot tempReg = GetRegisterSpace(WasmTypes::I32)->AcquireTmpRegister();
777777
info = EmitInfo(tempReg, WasmTypes::I32);
778-
m_writer->AsmReg1(Js::OpCodeAsmJs::CurrentMemory_Int, tempReg);
778+
m_writer->AsmReg1(Js::OpCodeAsmJs::MemorySize_Int, tempReg);
779779
break;
780780
}
781-
case wbGrowMemory:
781+
case wbMemoryGrow:
782782
{
783783
info = EmitGrowMemory();
784784
break;

test/wasm/binary.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function makeReservedTest(name, body, msg) {
3030

3131
const tests = [
3232
makeReservedTest("memory.size reserved", [kExprMemorySize, 1], "memory.size reserved value must be 0"),
33-
makeReservedTest("memory.grow reserved", [kExprGrowMemory, 1], "memory.grow reserved value must be 0"),
33+
makeReservedTest("memory.grow reserved", [kExprMemoryGrow, 1], "memory.grow reserved value must be 0"),
3434
makeReservedTest("call_indirect reserved", [kExprCallIndirect, 1], "call_indirect reserved value must be 0"),
3535
];
3636

0 commit comments

Comments
 (0)