Add this-> where needed to appease permissive-

In some inheritance structures (access of a protected member of a
public base of a public base, for instance), permissive- mode has
a requirement that the variable is referenced using this->, which
we've previously had favorable discussions about anyway as a case
where the notation improves readability.

Author: Penguinwizzard

lib/Common/DataStructures/List.h

@@ -341,7 +341,7 @@ namespace JsUtil
         template <typename TConditionalFunction>
         bool Last(TConditionalFunction function, T& outElement)
         {
-            for (int i = count - 1; i >= 0; --i)
+            for (int i = this->count - 1; i >= 0; --i)
             {
                 if (function(this->buffer[i]))
                 {
@@ -420,7 +420,7 @@ namespace JsUtil
                 JsUtil::ExternalApi::RaiseOnIntOverflow();
             }
 
-            js_memcpy_s(buffer + this->count, availableByteSpace, items, givenBufferSize);
+            js_memcpy_s(this->buffer + this->count, availableByteSpace, items, givenBufferSize);
             this->count = requiredSize;
 
             return requiredSize; //Returns count

lib/Common/Memory/AutoAllocatorObjectPtr.h

@@ -61,10 +61,10 @@ class AutoAllocatorArrayPtr : public BasePtr<T>
 private:
     void Clear()
     {
-        if (ptr != nullptr)
+        if (this->ptr != nullptr)
         {
-            DeleteArray<TAllocator>(m_allocator, m_elementCount, ptr);
-            ptr = nullptr;
+            DeleteArray<TAllocator>(m_allocator, this->m_elementCount, this->ptr);
+            this->ptr = nullptr;
         }
     }
 };
@@ -98,14 +98,14 @@ class AutoAllocatorObjectArrayPtr : public AutoAllocatorArrayPtr<T*, ArrayAlloca
 private:
     void Clear()
     {
-        if (ptr != nullptr)
+        if (this->ptr != nullptr)
         {
-            for (size_t i = 0; i < m_elementCount; i++)
+            for (size_t i = 0; i < this->m_elementCount; i++)
             {
-                if (ptr[i] != nullptr)
+                if (this->ptr[i] != nullptr)
                 {
-                    DeleteObject<TAllocator>(m_allocator, ptr[i]);
-                    ptr[i] = nullptr;
+                    DeleteObject<TAllocator>(this->m_allocator, this->ptr[i]);
+                    this->ptr[i] = nullptr;
                 }
             }
         }

lib/Common/Memory/AutoPtr.h

@@ -76,18 +76,18 @@ class AutoArrayAndItemsPtr : public AutoArrayPtr<T>
 private:
     void Clear()
     {
-        if (ptr != nullptr){
+        if (this->ptr != nullptr){
             for (size_t i = 0; i < this->m_elementCount; i++)
             {
-                if (ptr[i] != nullptr)
+                if (this->ptr[i] != nullptr)
                 {
-                    ptr[i]->CleanUp();
-                    ptr[i] = nullptr;
+                    this->ptr[i]->CleanUp();
+                    this->ptr[i] = nullptr;
                 }
             }
 
-            HeapDeleteArray(m_elementCount, ptr);
-            ptr = nullptr;
+            HeapDeleteArray(this->m_elementCount, this->ptr);
+            this->ptr = nullptr;
         }
     }
 };