Slight change to annotate overflow as unlikely in command line parameter handling

Penguinwizzard · Penguinwizzard · commit 3878d555b8da · 2018-06-20T17:08:01.000-07:00
diff --git a/bin/ch/JITProcessManager.cpp b/bin/ch/JITProcessManager.cpp
@@ -52,7 +52,7 @@ HRESULT JITProcessManager::CreateServerProcess(int argc, __in_ecount(argc) LPWST
     STARTUPINFOW si = { 0 };
 
     // overallocate constant cmd line (jshost -jitserver:<guid>)
-    size_t cmdLineSize = (MAX_PATH + argc) * sizeof(WCHAR);
+    size_t cmdLineSize = (MAX_PATH + (size_t)argc) * sizeof(WCHAR);
     for (int i = 0; i < argc; ++i)
     {
         // calculate space requirement for each arg

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ HRESULT JITProcessManager::CreateServerProcess(int argc, __in_ecount(argc) LPWST`
`52`	`52`	`STARTUPINFOW si = { 0 };`
`53`	`53`
`54`	`54`	`// overallocate constant cmd line (jshost -jitserver:<guid>)`
`55`		`- size_t cmdLineSize = (MAX_PATH + argc) * sizeof(WCHAR);`
	`55`	`+ size_t cmdLineSize = (MAX_PATH + (size_t)argc) * sizeof(WCHAR);`
`56`	`56`	`for (int i = 0; i < argc; ++i)`
`57`	`57`	`{`
`58`	`58`	`// calculate space requirement for each arg`