Bug fix for enabling inline args opt due to eliminated arguments object references

rajatd · rajatd · commit 4ad808379fa2 · 2019-01-07T11:05:26.000-08:00
diff --git a/lib/Backend/GlobOptBailOut.cpp b/lib/Backend/GlobOptBailOut.cpp
@@ -483,8 +483,9 @@ void
 GlobOpt::ProcessInlineeEnd(IR::Instr* instr)
 {
     if (!PHASE_OFF(Js::StackArgLenConstOptPhase, instr->m_func) && 
-        (!instr->m_func->GetJITFunctionBody()->UsesArgumentsObject() || instr->m_func->IsStackArgsEnabled())
-        && instr->m_func->unoptimizableArgumentsObjReference == 0 && instr->m_func->unoptimizableArgumentsObjReferenceInInlinees == 0)
+        !IsLoopPrePass() &&
+        (!instr->m_func->GetJITFunctionBody()->UsesArgumentsObject() || instr->m_func->IsStackArgsEnabled()) &&
+        instr->m_func->unoptimizableArgumentsObjReference == 0 && instr->m_func->unoptimizableArgumentsObjReferenceInInlinees == 0)
     {
         instr->m_func->hasUnoptimizedArgumentsAccess = false;
         if (!instr->m_func->m_hasInlineArgsOpt && DoInlineArgsOpt(instr->m_func))

Original file line number	Diff line number	Diff line change
`@@ -483,8 +483,9 @@ void`
`483`	`483`	`GlobOpt::ProcessInlineeEnd(IR::Instr* instr)`
`484`	`484`	`{`
`485`	`485`	`if (!PHASE_OFF(Js::StackArgLenConstOptPhase, instr->m_func) &&`
`486`		`- (!instr->m_func->GetJITFunctionBody()->UsesArgumentsObject() \|\| instr->m_func->IsStackArgsEnabled())`
`487`		`- && instr->m_func->unoptimizableArgumentsObjReference == 0 && instr->m_func->unoptimizableArgumentsObjReferenceInInlinees == 0)`
	`486`	`+ !IsLoopPrePass() &&`
	`487`	`+ (!instr->m_func->GetJITFunctionBody()->UsesArgumentsObject() \|\| instr->m_func->IsStackArgsEnabled()) &&`
	`488`	`+ instr->m_func->unoptimizableArgumentsObjReference == 0 && instr->m_func->unoptimizableArgumentsObjReferenceInInlinees == 0)`
`488`	`489`	`{`
`489`	`490`	`instr->m_func->hasUnoptimizedArgumentsAccess = false;`
`490`	`491`	`if (!instr->m_func->m_hasInlineArgsOpt && DoInlineArgsOpt(instr->m_func))`