[MERGE #5600 @pleath] Stop sharing inline caches by default

Merge pull request #5600 from pleath:dontsharecache

Sharing inline caches across more than one instruction causes problems for objtypespec-related transformations and in particular for depolymorphication. Disable it by default preparatory to re-enabling depolymorphication.

Author: pleath

lib/Common/ConfigFlagsList.h

@@ -763,7 +763,7 @@ PHASE(All)
 #define DEFAULT_CONFIG_LibraryStackFrameDebugger    (false)
 
 #define DEFAULT_CONFIG_FuncObjectInlineCacheThreshold   (2) // Maximum number of inline caches a function body may have to allow for inline caches to be allocated on the function object.
-#define DEFAULT_CONFIG_ShareInlineCaches (true)
+#define DEFAULT_CONFIG_ShareInlineCaches (false)
 #define DEFAULT_CONFIG_InlineCacheInvalidationListCompactionThreshold (4)
 #define DEFAULT_CONFIG_ConstructorCacheInvalidationThreshold (500)
 

lib/Runtime/ByteCode/FuncInfo.h

@@ -674,7 +674,7 @@ class FuncInfo
         }
 
         // If we share inline caches we should never have more than one entry in the list.
-        Assert(Js::FunctionBody::ShouldShareInlineCaches() || cacheList->Count() <= 1);
+        Assert(!Js::FunctionBody::ShouldShareInlineCaches() || cacheList->Count() <= 1);
 
         InlineCacheUnit cacheIdUnit;