[MERGE #5137 @sigatrev] implement Array.prototype.filter in javascript

Merge pull request #5137 from sigatrev:jsFilter

Implementing built-ins in JavaScript allows the JIT to optimize calls that must otherwise behave generically. This can provide significant performance improvements, particularly for array operations that loop over the array.

In a microbenchmark calling filter 1000 times on a 10000 element array, the JS implementation was 13x faster in the best case, and 20% faster in the worst case.

```
for (var i = 0; i < 1000; ++i) {
  a.filter(()=>false) // best case, array is never grown
}
// js: 30 ms
// c++: 400ms

for (var i = 0; i < 1000; ++i) {
  a.filter(()=>true) // worst case
}
// js: 550 ms
// c++: 700 ms
```

Adding a JIT fast path for __chakraLibrary.arrayCreateDataPropertyOrThrow similar to normal array assignment would drop the always-true case to 230 ms.

Author: sigatrev

RegenAllByteCodeNoBuild.cmd

@@ -32,4 +32,9 @@ setlocal
     call GenByteCode.cmd
     call GenByteCode.cmd -nojit
   popd
+
+  pushd %_reporoot%\lib\Runtime\Library\JsBuiltIn
+    call GenByteCode.cmd
+    call GenByteCode.cmd -nojit
+  popd
 endlocal

lib/Runtime/Base/JnDirectFields.h

@@ -605,6 +605,8 @@ ENTRY(registerChakraLibraryFunction)
 ENTRY(registerFunction)
 ENTRY(toLength)
 ENTRY(toInteger)
+ENTRY(arraySpeciesCreate)
+ENTRY(arrayCreateDataPropertyOrThrow)
 
 // EngineInterfaceObject built-ins
 ENTRY(builtInGlobalObjectEntryIsFinite)
@@ -666,6 +668,7 @@ ENTRY(raiseObjectIsNonExtensible)
 ENTRY(raiseOptionValueOutOfRange_3)
 ENTRY(raiseOptionValueOutOfRange)
 ENTRY(raiseThis_NullOrUndefined)
+ENTRY(raiseFunctionArgument_NeedFunction)
 
 // Promise (ChakraFull)
 ENTRY(Promise)

lib/Runtime/ByteCode/ByteCodeCacheReleaseFileVersion.h

@@ -4,6 +4,6 @@
 //-------------------------------------------------------------------------------------------------------
 // NOTE: If there is a merge conflict the correct fix is to make a new GUID.
 
-// {9F2ABB67-7351-401E-911C-9919B54F761C}
+// {9B3A48D4-C8EF-46CF-A473-14CB0DA3244F}
 const GUID byteCodeCacheReleaseFileVersion =
-{ 0x9F2ABB67, 0x7351, 0x401E, { 0x91, 0x1C, 0x99, 0x19, 0xB5, 0x4F, 0x76, 0x1C } };
+{ 0x9B3A48D4, 0xC8EF, 0x46CF, { 0xA4, 0x73, 0x14, 0xCB, 0x0D, 0xA3, 0x24, 0x4F } };

lib/Runtime/Library/EngineInterfaceObjectBuiltIns.h

@@ -29,7 +29,6 @@ GlobalBuiltIn(JavascriptArray, EntryPush)
 GlobalBuiltIn(JavascriptArray, EntryJoin)
 GlobalBuiltIn(JavascriptArray, EntryMap)
 GlobalBuiltIn(JavascriptArray, EntryReduce)
-GlobalBuiltIn(JavascriptArray, EntryFilter)
 GlobalBuiltIn(JavascriptArray, EntrySlice)
 GlobalBuiltIn(JavascriptArray, EntryConcat)
 
@@ -63,3 +62,4 @@ BuiltInRaiseException2(TypeError, NeedObjectOfType)
 BuiltInRaiseException1(RangeError, InvalidCurrencyCode)
 BuiltInRaiseException(TypeError, MissingCurrencyCode)
 BuiltInRaiseException(RangeError, InvalidDate)
+BuiltInRaiseException1(TypeError, FunctionArgument_NeedFunction)

lib/Runtime/Library/InJavascript/Intl.js.bc.32b.h

@@ -3032,6 +3032,20 @@ namespace Js
         }
     }
 
+    void JavascriptArray::CreateDataPropertyOrThrow(RecyclableObject * obj, BigIndex index, Var item, ScriptContext * scriptContext)
+    {
+        JS_REENTRANCY_LOCK(jsReentLock, scriptContext->GetThreadContext());
+        JavascriptArray * arr = JavascriptOperators::TryFromVar<JavascriptArray>(obj);
+        if (arr != nullptr)
+        {
+            arr->GenericDirectSetItemAt(index, item);
+        }
+        else
+        {
+            JS_REENTRANT(jsReentLock, ThrowErrorOnFailure(SetArrayLikeObjects(obj, index, item), scriptContext, index));
+        }
+    }
+
     BOOL JavascriptArray::SetArrayLikeObjects(RecyclableObject* pDestObj, uint32 idxDest, Var aItem)
     {
         return pDestObj->SetItem(idxDest, aItem, Js::PropertyOperation_ThrowIfNotExtensible);

lib/Runtime/Library/InJavascript/Intl.js.bc.64b.h

@@ -862,9 +862,11 @@ namespace Js
         static bool PromoteToBigIndex(BigIndex lhs, BigIndex rhs);
         static bool PromoteToBigIndex(BigIndex lhs, uint32 rhs);
         static JavascriptArray* ConcatFloatArgs(JavascriptNativeFloatArray* pDestArray, TypeId* remoteTypeIds, Js::Arguments& args, ScriptContext* scriptContext);
-    private:
+
         template<typename T=uint32>
         static RecyclableObject* ArraySpeciesCreate(Var pThisArray, T length, ScriptContext* scriptContext, bool *pIsIntArray = nullptr, bool *pIsFloatArray = nullptr, bool *pIsBuiltinArrayCtor = nullptr);
+        static void CreateDataPropertyOrThrow(RecyclableObject * obj, BigIndex index, Var item, ScriptContext * scriptContext);
+    private:
         template <typename T, typename R> static R ConvertToIndex(T idxDest, ScriptContext* scriptContext) { Throw::InternalError(); return 0; }
         static BOOL SetArrayLikeObjects(RecyclableObject* pDestObj, uint32 idxDest, Var aItem);
         static BOOL SetArrayLikeObjects(RecyclableObject* pDestObj, BigIndex idxDest, Var aItem);