Fixing HeapFree AV

akroshg · akroshg · commit 5da225cc361c · 2018-10-19T14:01:11.000-07:00
We have allocated objectBeforeCollectCallbackList object on HeapAllocator but
we freed this by ArenaAllocator::Free function. Fixed that by allocate that object
onto ArenaAllocator.
diff --git a/lib/Common/Memory/Recycler.cpp b/lib/Common/Memory/Recycler.cpp
@@ -8962,7 +8962,7 @@ void Recycler::SetObjectBeforeCollectCallback(void* object,
     if (objectBeforeCollectCallbackList == nullptr)
     {
         if (callback == nullptr) return;
-        objectBeforeCollectCallbackList = HeapNew(ObjectBeforeCollectCallbackList, &this->objectBeforeCollectCallbackArena);
+        objectBeforeCollectCallbackList = Anew(&this->objectBeforeCollectCallbackArena, ObjectBeforeCollectCallbackList, &this->objectBeforeCollectCallbackArena);
     }
 
     // only allow 1 callback per object

Original file line number	Diff line number	Diff line change
`@@ -8962,7 +8962,7 @@ void Recycler::SetObjectBeforeCollectCallback(void* object,`
`8962`	`8962`	`if (objectBeforeCollectCallbackList == nullptr)`
`8963`	`8963`	`{`
`8964`	`8964`	`if (callback == nullptr) return;`
`8965`		`- objectBeforeCollectCallbackList = HeapNew(ObjectBeforeCollectCallbackList, &this->objectBeforeCollectCallbackArena);`
	`8965`	`+ objectBeforeCollectCallbackList = Anew(&this->objectBeforeCollectCallbackArena, ObjectBeforeCollectCallbackList, &this->objectBeforeCollectCallbackArena);`
`8966`	`8966`	`}`
`8967`	`8967`
`8968`	`8968`	`// only allow 1 callback per object`