[MERGE #5242 @Cellule] Remove _ABSTRACT

Merge pull request #5242 from Cellule:abstract

Remove _ABSTRACT, most classes were already pure virtual and I deleted the constructor of the others.

Author: Cellule

lib/Common/CommonPal.h

@@ -498,13 +498,6 @@ DWORD __cdecl CharUpperBuffW(const char16* lpsz, DWORD  cchLength);
 #include <stdint.h>
 #endif
 
-// MSVC specific keywords
-#if defined(_MSC_VER)
-#define _ABSTRACT abstract
-#else
-#define _ABSTRACT
-#endif
-
 // `typename QualifiedName` declarations outside of template code not supported before MSVC 2015 update 1
 #if defined(_MSC_VER) && _MSC_VER < 1910
 #define _TYPENAME

lib/Common/DataStructures/BaseDictionary.h

@@ -1180,8 +1180,10 @@ namespace JsUtil
 
     protected:
         template<class TDictionary, class Leaf>
-        class IteratorBase _ABSTRACT
+        class IteratorBase
         {
+            IteratorBase() = delete;
+
         protected:
             EntryType *const entries;
             int entryIndex;

lib/Runtime/Base/ThreadContext.cpp

@@ -4814,6 +4814,7 @@ void JsReentLock::MutateArrayObject(Js::Var arrayObject)
     }
 }
 
+
 void JsReentLock::MutateArrayObject()
 {
     if (CONFIG_FLAG(EnableArrayTypeMutation))

lib/Runtime/Base/ThreadContext.h

@@ -57,7 +57,7 @@ struct IProjectionContext
 
 class ThreadContext;
 
-class InterruptPoller _ABSTRACT
+class InterruptPoller
 {
     // Interface with a polling object located in the hosting layer.
 

lib/Runtime/Base/ThreadServiceWrapper.h

@@ -5,7 +5,7 @@
 #pragma once
 // This class is used to communicate between ThreadContext and JavascriptThreadService
 
-class ThreadServiceWrapper _ABSTRACT
+class ThreadServiceWrapper
 {
 public:
     virtual bool ScheduleNextCollectOnExit() = 0;

lib/Runtime/Language/InlineCache.h

@@ -473,7 +473,7 @@ namespace Js
     CompileAssert(sizeof(InlineCache) == sizeof(InlineCacheAllocator::CacheLayout));
     CompileAssert(offsetof(InlineCache, invalidationListSlotPtr) == offsetof(InlineCacheAllocator::CacheLayout, strongRef));
 
-    class PolymorphicInlineCache _ABSTRACT : public FinalizableObject
+    class PolymorphicInlineCache : public FinalizableObject
     {
         DECLARE_RECYCLER_VERIFY_MARK_FRIEND()
 #ifdef INLINE_CACHE_STATS

lib/Runtime/Library/ArgumentsObject.h

@@ -6,7 +6,7 @@
 
 namespace Js
 {
-    class ArgumentsObject _ABSTRACT : public DynamicObject
+    class ArgumentsObject : public DynamicObject
     {
     private:
         static PropertyId specialPropertyIds[];

lib/Runtime/Library/ConcatString.h

@@ -82,7 +82,7 @@ namespace Js
     // Usage pattern:
     //   // Create concat tree using one of non-abstract derived classes.
     //   JavascriptString* result = concatTree->GetString();    // At this time we flatten the tree into 1 actual wchat_t* string.
-    class ConcatStringBase _ABSTRACT : public LiteralString // vtable will be switched to LiteralString's vtable after flattening
+    class ConcatStringBase : public LiteralString // vtable will be switched to LiteralString's vtable after flattening
     {
         friend JavascriptString;
 

lib/Runtime/Library/JavascriptArrayIndexEnumeratorBase.h

@@ -6,7 +6,7 @@
 
 namespace Js
 {
-    class JavascriptArrayIndexEnumeratorBase _ABSTRACT : public JavascriptEnumerator
+    class JavascriptArrayIndexEnumeratorBase : public JavascriptEnumerator
     {
     protected:
         Field(JavascriptArray*) arrayObject;

lib/Runtime/Library/JavascriptString.h

@@ -29,12 +29,15 @@ namespace Js
     bool IsValidCharCount(size_t charCount);
     const charcount_t k_InvalidCharCount = static_cast<charcount_t>(-1);
 
-    class JavascriptString _ABSTRACT : public RecyclableObject
+    class JavascriptString : public RecyclableObject
     {
         friend Lowerer;
         friend LowererMD;
         friend bool IsValidCharCount(size_t);
 
+        JavascriptString() = delete;
+        JavascriptString(JavascriptString&) = delete;
+
     private:
         Field(const char16*) m_pszValue;         // Flattened, '\0' terminated contents
         Field(charcount_t) m_charLength;          // Length in characters, not including '\0'.