disable warnings

Penguinwizzard · Penguinwizzard · commit 6285aee5d939 · 2018-06-25T15:06:12.000-07:00
diff --git a/bin/NativeTests/CodexTests.cpp b/bin/NativeTests/CodexTests.cpp
@@ -3,6 +3,9 @@
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 #include <process.h>
 #include "Codex\Utf8Codex.h"
@@ -280,4 +283,4 @@ namespace CodexTest
         
         RunUtf8DecodeTestCase(testCases, utf8::DecodeUnitsIntoAndNullTerminateNoAdvance);
     }
-};
+};
diff --git a/bin/NativeTests/FileLoadHelpers.cpp b/bin/NativeTests/FileLoadHelpers.cpp
@@ -114,7 +114,7 @@ HRESULT FileLoadHelpers::LoadScriptFromFile(LPCSTR filename, LPCWSTR& contents,
         utf8::DecodeOptions decodeOptions = utf8::doAllowInvalidWCHARs;
 
         UINT cUtf16Chars = utf8::ByteIndexIntoCharacterIndex(pRawBytes, lengthBytes, decodeOptions);
-        contents = (LPCWSTR)HeapAlloc(GetProcessHeap(), 0, (cUtf16Chars + 1) * sizeof(WCHAR));
+        contents = (LPCWSTR)HeapAlloc(GetProcessHeap(), 0, (cUtf16Chars + (size_t)1) * sizeof(WCHAR));
         if (nullptr == contents)
         {
             fwprintf(stderr, _u("out of memory"));
diff --git a/bin/NativeTests/FunctionExecutionTest.cpp b/bin/NativeTests/FunctionExecutionTest.cpp
@@ -3,6 +3,9 @@
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 #include "FunctionExecutionTest.h"
 
diff --git a/bin/NativeTests/FunctionExecutionTest.h b/bin/NativeTests/FunctionExecutionTest.h
@@ -6,6 +6,7 @@
 // This file contains stubs needed to make FunctionExecutionTest successfully compile and link as well
 // as a means to emulate behavior of objects that interact with FunctionExecutionStateMachine
 
+#include "..\..\lib\Common\Warnings.h"
 #include "..\..\lib\Common\Core\CommonMinMax.h"
 
 #define ENUM_CLASS_HELPERS(x, y)
diff --git a/bin/NativeTests/JsDiagApiTest.cpp b/bin/NativeTests/JsDiagApiTest.cpp
@@ -4,6 +4,9 @@
 //-------------------------------------------------------------------------------------------------------
 
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 #include <process.h>
 
diff --git a/bin/NativeTests/JsRTApiTest.cpp b/bin/NativeTests/JsRTApiTest.cpp
@@ -3,6 +3,9 @@
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 #include <array>
 #include <process.h>
diff --git a/bin/NativeTests/MemoryPolicyTest.cpp b/bin/NativeTests/MemoryPolicyTest.cpp
@@ -3,6 +3,9 @@
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 
 #pragma warning(disable:6387) // suppressing preFAST which raises warning for passing null to the JsRT APIs
diff --git a/bin/NativeTests/NativeTests.cpp b/bin/NativeTests/NativeTests.cpp
@@ -9,6 +9,9 @@
 // conversion from 'int' to 'char', possible loss of data
 #pragma warning(disable:4242)
 #pragma warning(disable:4244)
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 #pragma warning(pop)
 
diff --git a/bin/NativeTests/ThreadServiceTest.cpp b/bin/NativeTests/ThreadServiceTest.cpp
@@ -4,6 +4,9 @@
 //-------------------------------------------------------------------------------------------------------
 
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 
 #pragma warning(disable:6387) // suppressing preFAST which raises warning for passing null to the JsRT APIs
diff --git a/bin/NativeTests/UnicodeTextTests.cpp b/bin/NativeTests/UnicodeTextTests.cpp
@@ -4,6 +4,9 @@
 //-------------------------------------------------------------------------------------------------------
 
 #include "stdafx.h"
+#pragma warning(disable:26439)
+#pragma warning(disable:26451)
+#pragma warning(disable:26495)
 #include "catch.hpp"
 
 namespace UnicodeTextTest
diff --git a/lib/Common/Warnings.h b/lib/Common/Warnings.h
@@ -38,17 +38,27 @@
 #pragma warning(disable:28112)      // A variable (processNativeCodeSize) which is accessed via an Interlocked function must always be accessed via an Interlocked function. See line 1024:  It is not always safe to access a variable which is accessed via the Interlocked* family of functions in any other way.
 #pragma warning(disable:28159)      // Consider using 'GetTickCount64' instead of 'GetTickCount'. Reason: GetTickCount overflows roughly every 49 days.  Code that does not take that into account can loop indefinitely.  GetTickCount64 operates on 64 bit values and does not have that problem
 
+#pragma warning(disable:6011)       // potentially dereferencing null pointer
 #pragma warning(disable:6235)       // Logical OR with non-zero constant on the left: 1 || <expr>
 #pragma warning(disable:6236)       // Logical-OR with non-zero constant, e.g., <expr> || 1.  We end up with a lot of these in release builds because certain macros (notably CONFIG_FLAG) expand to compile-time constants in release builds and not in debug builds.
 #pragma warning(disable:6327)       // False constant expr on left side of AND, so right side never evaluated for effects -- e.g., 0 && <expr>
 #pragma warning(disable:6239)       // NONZEROLOGICALAND:  1 && <expr> ?
 #pragma warning(disable:6240)       // LOGICALANDNONZERO:  <expr> && 1 ?
+#pragma warning(disable:6271)       // extra argument provided beyond format string - typically due to macro issues
+#pragma warning(disable:6323)       // use of arithmetic operator on boolean types
+#pragma warning(disable:6340)       // sign mismatch on printf format string
+#pragma warning(disable:6387)       // argument to system library function could be null, which is technically UB but generally just an AV (or harmless)
 #pragma warning(disable:25037)      // True constant expr in AND, e.g., <expr> && 1.
 #pragma warning(disable:25038)      // False constant expr in AND, e.g., <expr> && 0.
 #pragma warning(disable:25039)      // True Constant Expr in OR.  Seems to be a duplicate of 6236.
 #pragma warning(disable:25040)      // False Constant Expr in OR, e.g., <expr> || 0.
 #pragma warning(disable:25041)      // 'if' condition is always true
 #pragma warning(disable:25042)      // 'if' condition is always false
+#pragma warning(disable:26437)      // avoid slicing - this is more of a guideline than a rule, and we don't do it often regardless
+#pragma warning(disable:26439)      // noexcept specifier implied
+#pragma warning(disable:26451)      // doing math on smaller types than possible
+#pragma warning(disable:26454)      // arithmetic overflow at compile time (due to us doing "0 - 1" intentionally)
+#pragma warning(disable:26495)      // member not initialized (generally due to our heavy use of out-of-thread-zeroing allocators)
 
 #ifndef NTBUILD
 // Would be nice to clean these up.

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ HRESULT FileLoadHelpers::LoadScriptFromFile(LPCSTR filename, LPCWSTR& contents,`
`114`	`114`	`utf8::DecodeOptions decodeOptions = utf8::doAllowInvalidWCHARs;`
`115`	`115`
`116`	`116`	`UINT cUtf16Chars = utf8::ByteIndexIntoCharacterIndex(pRawBytes, lengthBytes, decodeOptions);`
`117`		`- contents = (LPCWSTR)HeapAlloc(GetProcessHeap(), 0, (cUtf16Chars + 1) * sizeof(WCHAR));`
	`117`	`+ contents = (LPCWSTR)HeapAlloc(GetProcessHeap(), 0, (cUtf16Chars + (size_t)1) * sizeof(WCHAR));`
`118`	`118`	`if (nullptr == contents)`
`119`	`119`	`{`
`120`	`120`	`fwprintf(stderr, _u("out of memory"));`