[MERGE #5354 @dilijev] Fix #5349: Rename Atomics.wake to Atomics.notify, per ES spec change.

Merge pull request #5354 from dilijev:atomics-notify

Fix #5349

Author: dilijev

lib/Runtime/Base/JnDirectFields.h

@@ -731,7 +731,7 @@ ENTRY(compareExchange)
 ENTRY(exchange)
 ENTRY(isLockFree)
 ENTRY(wait)
-ENTRY(wake)
+ENTRY(notify)
 
 ENTRY(column)
 ENTRY(url)

lib/Runtime/Library/AtomicsObject.cpp

@@ -231,9 +231,9 @@ namespace Js
             : scriptContext->GetLibrary()->CreateStringFromCppLiteral(_u("timed-out"));
     }
 
-    Var AtomicsObject::EntryWake(RecyclableObject* function, CallInfo callInfo, ...)
+    Var AtomicsObject::EntryNotify(RecyclableObject* function, CallInfo callInfo, ...)
     {
-        ATOMICS_FUNCTION_ENTRY_CHECKS(2, "Atomics.wake");
+        ATOMICS_FUNCTION_ENTRY_CHECKS(2, "Atomics.notify");
 
         uint32 accessIndex = 0;
         TypedArrayBase *typedArrayBase = ValidateAndGetTypedArray(args[1], args[2], &accessIndex, scriptContext, true /*onlyInt32*/);

lib/Runtime/Library/AtomicsObject.h

@@ -24,7 +24,7 @@ namespace Js
             static FunctionInfo Store;
             static FunctionInfo Sub;
             static FunctionInfo Wait;
-            static FunctionInfo Wake;
+            static FunctionInfo Notify;
             static FunctionInfo Xor;
         };
 
@@ -38,7 +38,7 @@ namespace Js
         static Var EntryStore(RecyclableObject* function, CallInfo callInfo, ...);
         static Var EntrySub(RecyclableObject* function, CallInfo callInfo, ...);
         static Var EntryWait(RecyclableObject* function, CallInfo callInfo, ...);
-        static Var EntryWake(RecyclableObject* function, CallInfo callInfo, ...);
+        static Var EntryNotify(RecyclableObject* function, CallInfo callInfo, ...);
         static Var EntryXor(RecyclableObject* function, CallInfo callInfo, ...);
 
     private:

lib/Runtime/Library/JavascriptBuiltInFunctionList.h

@@ -501,7 +501,7 @@ BUILTIN(AtomicsObject, Or, EntryOr, FunctionInfo::ErrorOnNew)
 BUILTIN(AtomicsObject, Store, EntryStore, FunctionInfo::ErrorOnNew)
 BUILTIN(AtomicsObject, Sub, EntrySub, FunctionInfo::ErrorOnNew)
 BUILTIN(AtomicsObject, Wait, EntryWait, FunctionInfo::ErrorOnNew)
-BUILTIN(AtomicsObject, Wake, EntryWake, FunctionInfo::ErrorOnNew)
+BUILTIN(AtomicsObject, Notify, EntryNotify, FunctionInfo::ErrorOnNew)
 BUILTIN(AtomicsObject, Xor, EntryXor, FunctionInfo::ErrorOnNew)
 
 #undef BUILTIN_TEMPLATE

lib/Runtime/Library/JavascriptLibrary.cpp

@@ -1824,7 +1824,7 @@ namespace Js
         library->AddFunctionToLibraryObject(atomicsObject, PropertyIds::store, &AtomicsObject::EntryInfo::Store, 3);
         library->AddFunctionToLibraryObject(atomicsObject, PropertyIds::sub, &AtomicsObject::EntryInfo::Sub, 3);
         library->AddFunctionToLibraryObject(atomicsObject, PropertyIds::wait, &AtomicsObject::EntryInfo::Wait, 4);
-        library->AddFunctionToLibraryObject(atomicsObject, PropertyIds::wake, &AtomicsObject::EntryInfo::Wake, 3);
+        library->AddFunctionToLibraryObject(atomicsObject, PropertyIds::notify, &AtomicsObject::EntryInfo::Notify, 3);
         library->AddFunctionToLibraryObject(atomicsObject, PropertyIds::xor_, &AtomicsObject::EntryInfo::Xor, 3);
 
         if (atomicsObject->GetScriptContext()->GetConfig()->IsES6ToStringTagEnabled())
@@ -7389,7 +7389,7 @@ namespace Js
         REG_OBJECTS_LIB_FUNC(store, AtomicsObject::EntryStore);
         REG_OBJECTS_LIB_FUNC(sub, AtomicsObject::EntrySub);
         REG_OBJECTS_LIB_FUNC(wait, AtomicsObject::EntryWait);
-        REG_OBJECTS_LIB_FUNC(wake, AtomicsObject::EntryWake);
+        REG_OBJECTS_LIB_FUNC(notify, AtomicsObject::EntryNotify);
         REG_OBJECTS_LIB_FUNC(xor_, AtomicsObject::EntryXor);
 
         return hr;

test/es7/atomics_test.js

@@ -25,7 +25,7 @@ var atomicsFunctionsList = [
 
 var atomicsFunctionsList2 = [
     {op : Atomics.wait, fullname: "Atomics.wait", onlyInt32:true, length : 4},
-    {op : Atomics.wake, fullname: "Atomics.wake", onlyInt32:true, length : 3},
+    {op : Atomics.notify, fullname: "Atomics.notify", onlyInt32:true, length : 3},
 ];
 
 var allAtomicsFunctionsList = [...atomicsFunctionsList, ...atomicsFunctionsList2, {op : Atomics.isLockFree, fullname: "Atomics.isLockFree", length : 1}];
@@ -199,23 +199,23 @@ var tests = [{
 		}
 	},
     {
-		name : "Atomics.wake negative scenario",
+		name : "Atomics.notify negative scenario",
 		body : function () {
             [[0, 4, 4], [3, 2, 8]].forEach(function([offset, length, elements]) {
                 var sab = makeSharedArrayBuffer(Int32Array.BYTES_PER_ELEMENT * elements);
                 var view = new Int32Array(sab, offset * Int32Array.BYTES_PER_ELEMENT, length);
 
-                assert.throws(() => Atomics.wake(view), RangeError, "Calling Atomics.wake with 1 param only is not valid", "Atomics.wake: function called with too few arguments");
+                assert.throws(() => Atomics.notify(view), RangeError, "Calling Atomics.notify with 1 param only is not valid", "Atomics.notify: function called with too few arguments");
                 [undefined, 1.1, "hi", NaN, {}].forEach(function (index) {
-                    Atomics.wake(view, index, 1);
+                    Atomics.notify(view, index, 1);
                 });
 
                 [-1, Infinity, -Infinity].forEach(function (index) {
-                    assert.throws(() => Atomics.wake(view, index, 1), RangeError, "Only positive interger allowed, not " + index, "Access index is out of range");
+                    assert.throws(() => Atomics.notify(view, index, 1), RangeError, "Only positive interger allowed, not " + index, "Access index is out of range");
                 });
 
-                assert.throws(() => Atomics.wake(view, elements, 1), RangeError, "index is out of bound " + elements, "Access index is out of range");
-                assert.throws(() => Atomics.wake(view, length, 1), RangeError, "index is out of bound " + length, "Access index is out of range");
+                assert.throws(() => Atomics.notify(view, elements, 1), RangeError, "index is out of bound " + elements, "Access index is out of range");
+                assert.throws(() => Atomics.notify(view, length, 1), RangeError, "index is out of bound " + length, "Access index is out of range");
             });
 		}
 	},