Update global toStringTag to match attributes from v8

Author: sethbrenith

lib/Runtime/Library/JavascriptLibrary.cpp

@@ -1142,7 +1142,10 @@ namespace Js
         AddMember(globalObject, PropertyIds::Infinity, positiveInfinite, PropertyNone);
         AddMember(globalObject, PropertyIds::undefined, undefinedValue, PropertyNone);
         // Note: for global object, we need to set toStringTag to global like other engines (v8)
-        AddMember(globalObject, PropertyIds::_symbolToStringTag, scriptContext->GetPropertyString(PropertyIds::global) , PropertyNone);
+        if (globalObject->GetScriptContext()->GetConfig()->IsES6ToStringTagEnabled())
+        {
+            AddMember(globalObject, PropertyIds::_symbolToStringTag, scriptContext->GetPropertyString(PropertyIds::global), PropertyConfigurable | PropertyWritable | PropertyEnumerable);
+        }
 
         // Note: Any global function added/removed/changed here should also be updated in JavascriptLibrary::ProfilerRegisterBuiltinFunctions
         // so that the new functions show up in the profiler too.

test/Debugger/JsDiagGetStackProperties.js.dbg.baseline

@@ -3,6 +3,7 @@
     "this": "Object {...}",
     "{exception}": "number 1",
     "locals": {
+      "Symbol.toStringTag": "string global",
       "globalVar": "undefined undefined",
       "FuncLevel1": "function <large string>",
       "outerFunc1": "function <large string>"
@@ -12,6 +13,7 @@
     "this": "Object {...}",
     "{exception}": "Error Caught Error",
     "locals": {
+      "Symbol.toStringTag": "string global",
       "globalVar": "undefined undefined",
       "FuncLevel1": "function <large string>",
       "outerFunc1": "function <large string>"
@@ -44,6 +46,7 @@
       "level1Var": "Object {...}"
     },
     "globals": {
+      "Symbol.toStringTag": "string global",
       "globalVar": "Object {...}",
       "FuncLevel1": "function <large string>",
       "outerFunc1": "function <large string>"
@@ -97,6 +100,7 @@
       }
     },
     "globals": {
+      "Symbol.toStringTag": "string global",
       "globalVar": "Object {...}",
       "FuncLevel1": "function <large string>",
       "outerFunc1": "function <large string>"

test/Debugger/MultipleContextStack.js.dbg.baseline

@@ -82,6 +82,7 @@
       "x": "undefined undefined"
     },
     "globals": {
+      "Symbol.toStringTag": "string global",
       "script1": "Object {...}",
       "script2": "Object {...}",
       "Func2": "function <large string>",

test/DebuggerCommon/ES6_intl_simple_attach.js.dbg.baseline

@@ -23,6 +23,7 @@
       }
     },
     "globals": {
+      "Symbol.toStringTag": "string global",
       "x": "undefined undefined",
       "Run": "function <large string>"
     }

test/DebuggerCommon/ES6_letconst_const_reassignment_globalscope.js.dbg.baseline

@@ -5,7 +5,8 @@
     },
     "locals": {
       "a": "number 1",
-      "b": "number 2"
+      "b": "number 2",
+      "Symbol.toStringTag": "string global"
     },
     "globals": {}
   },

test/DebuggerCommon/ES6_letconst_eval_nonstrict.js.dbg.baseline

@@ -4,7 +4,8 @@
       "Symbol.toStringTag": "string global"
     },
     "locals": {
-      "a": "number 1"
+      "a": "number 1",
+      "Symbol.toStringTag": "string global"
     },
     "globals": {}
   }

test/DebuggerCommon/ES6_letconst_eval_strict_fn.js.dbg.baseline

@@ -14,6 +14,7 @@
       "a": "number 1"
     },
     "globals": {
+      "Symbol.toStringTag": "string global",
       "Run": "function <large string>"
     }
   },

test/DebuggerCommon/ES6_letconst_for.js.dbg.baseline

@@ -3,6 +3,7 @@
     "this": "Object {...}",
     "locals": {
       "y": "number 1",
+      "Symbol.toStringTag": "string global",
       "x": "number 1"
     }
   },
@@ -14,6 +15,7 @@
     "locals": {
       "z": "number 1",
       "y": "number 1",
+      "Symbol.toStringTag": "string global",
       "x": "number 1"
     },
     "globals": {}
@@ -22,6 +24,7 @@
     "this": "Object {...}",
     "locals": {
       "y": "number 2",
+      "Symbol.toStringTag": "string global",
       "x": "number 1"
     }
   },
@@ -33,6 +36,7 @@
     "locals": {
       "z": "number 1",
       "y": "number 2",
+      "Symbol.toStringTag": "string global",
       "x": "number 1"
     },
     "globals": {}
@@ -41,6 +45,7 @@
     "this": "Object {...}",
     "locals": {
       "y": "number 3",
+      "Symbol.toStringTag": "string global",
       "x": "number 1"
     }
   }

test/DebuggerCommon/ES6_letconst_forin.js.dbg.baseline

@@ -6,6 +6,7 @@
     },
     "locals": {
       "y": "string x",
+      "Symbol.toStringTag": "string global",
       "a": {
         "#__proto__": "Object {...}",
         "x": "number 2",
@@ -21,6 +22,7 @@
     },
     "locals": {
       "y": "string y",
+      "Symbol.toStringTag": "string global",
       "a": {
         "#__proto__": "Object {...}",
         "x": "number 2",

test/DebuggerCommon/ES6_letconst_redcl.js.dbg.baseline

@@ -10,7 +10,8 @@
     },
     "locals": {
       "a": "number 100",
-      "b": "number 200"
+      "b": "number 200",
+      "Symbol.toStringTag": "string global"
     },
     "globals": {}
   }