Save HR data on failfast

Author: tcare

lib/Common/Core/Assertions.h

@@ -77,12 +77,16 @@ extern int IsInAssert;
 
 #ifdef DBG
 #define AssertOrFailFast(x)                 Assert(x)
+#define AssertOrFailFastHR(x, hr)           Assert(x)
 #define AssertOrFailFastMsg(x, msg)         AssertMsg(x, msg)
+#define AssertOrFailFastMsgHR(x, msg)       AssertOrFailFastHR(x, hr)
 #define AnalysisAssertOrFailFast(x)         AnalysisAssert(x)
 #define AnalysisAssertOrFailFastMsg(x, msg) AnalysisAssertMsg(x, msg)
 #else
+#define AssertOrFailFastHR(x, hr)           do { if (!(x)) { Js::Throw::FatalInternalError(hr); } } while (false)
 #define AssertOrFailFast(x)                 do { if (!(x)) { Js::Throw::FatalInternalError(); } } while (false)
 #define AssertOrFailFastMsg(x, msg)         AssertOrFailFast(x)
+#define AssertOrFailFastMsgHR(x, msg)       AssertOrFailFastHR(x, hr)
 #define AnalysisAssertOrFailFast(x)         AssertOrFailFast(x)
 #define AnalysisAssertOrFailFastMsg(x, msg) AssertOrFailFast(x)
 #endif

lib/Common/Exceptions/Throw.cpp

@@ -66,10 +66,10 @@ namespace Js {
 #if defined(GENERATE_DUMP) && defined(STACK_BACK_TRACE)
     THREAD_LOCAL StackBackTrace * Throw::stackBackTrace = nullptr;
 #endif
-    void Throw::FatalInternalError()
+    void Throw::FatalInternalError(HRESULT hr)
     {
         int scenario = 2;
-        ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
+        ReportFatalException(NULL, hr, Fatal_Internal_Error, scenario);
     }
 
     void Throw::FatalInternalErrorEx(int scenario)

lib/Common/Exceptions/Throw.h

@@ -19,7 +19,7 @@ namespace Js {
         static void __declspec(noreturn) StackOverflow(ScriptContext *scriptContext, PVOID returnAddress);
         static void __declspec(noreturn) NotImplemented();
         static void __declspec(noreturn) InternalError();
-        static void __declspec(noreturn) FatalInternalError();
+        static void __declspec(noreturn) FatalInternalError(HRESULT hr = E_FAIL);
         static void __declspec(noreturn) FatalInternalErrorEx(int scenario);
         static void __declspec(noreturn) FatalInternalGlobalizationError();
 
@@ -163,7 +163,7 @@ namespace Js {
     else if (FAILED(hr)) \
     { \
         /* Intended to be the inverse of E_FAIL in CATCH_UNHANDLED_EXCEPTION */ \
-        AssertOrFailFast(false); \
+        AssertOrFailFastHR(false, hr); \
     }
 
 #define CATCH_UNHANDLED_EXCEPTION(hr) \