[MERGE #5165 @meg-gupta] OS#17035883 : Generate object check for Symbol compare lowering Found by OSS Fuzz

Merge pull request #5165 from meg-gupta:fixsymcmp

Author: Meghana Gupta

lib/Backend/Lower.cpp

@@ -23128,8 +23128,8 @@ bool Lowerer::GenerateFastBooleanAndObjectEqLikely(IR::Instr * instr, IR::Opnd *
     }
     else if (src1->GetValueType().IsLikelySymbol() && src2->GetValueType().IsLikelySymbol())
     {
-        this->GenerateSymbolTest(src1->AsRegOpnd(), instr, labelHelper, nullptr, false);
-        this->GenerateSymbolTest(src2->AsRegOpnd(), instr, labelHelper, nullptr, false);
+        this->GenerateSymbolTest(src1->AsRegOpnd(), instr, labelHelper, nullptr, true);
+        this->GenerateSymbolTest(src2->AsRegOpnd(), instr, labelHelper, nullptr, true);
     }
     else
     {

test/Bugs/rlexe.xml

@@ -467,4 +467,9 @@
       <compile-flags>-off:ArrayMissingValueCheckHoist</compile-flags>
     </default>
   </test>
+  <test>
+    <default>
+      <files>symcmpbug.js</files>
+    </default>
+  </test>
 </regress-exe>

test/Bugs/symcmpbug.js

@@ -0,0 +1,14 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+function symcmp(c1, c2) {
+    return (c1 !== c2);
+}
+
+var s = Symbol();
+symcmp(s, s);
+symcmp(s, s);
+symcmp(1, 2);
+print("Passed");