fix UT failure

Author: MikeHolman

lib/Backend/BackwardPass.cpp

@@ -8088,7 +8088,6 @@ BackwardPass::ProcessInlineeStart(IR::Instr* inlineeStart)
     inlineeStart->m_func->SetFirstArgOffset(inlineeStart);
 
     IR::Instr* startCallInstr = nullptr;
-    bool noImplicitCallsInInlinee = false;
     // Inlinee has no bailouts or implicit calls.  Get rid of the inline overhead.
     auto removeInstr = [&](IR::Instr* argInstr)
     {
@@ -8110,7 +8109,6 @@ BackwardPass::ProcessInlineeStart(IR::Instr* inlineeStart)
     // If there are no implicit calls - bailouts/throws - we can remove all inlining overhead.
     if (!inlineeStart->m_func->GetHasImplicitCalls())
     {
-        noImplicitCallsInInlinee = true;
         inlineeStart->IterateArgInstrs(removeInstr);
 
         inlineeStart->IterateMetaArgs([](IR::Instr* metArg)
@@ -8119,6 +8117,7 @@ BackwardPass::ProcessInlineeStart(IR::Instr* inlineeStart)
             return false;
         });
         inlineeStart->m_func->m_hasInlineArgsOpt = false;
+        inlineeStart->m_func->m_hasInlineOverheadRemoved = true;
         removeInstr(inlineeStart);
         return true;
     }

lib/Backend/Func.cpp

@@ -64,6 +64,7 @@ Func::Func(JitArenaAllocator *alloc, JITTimeWorkItem * workItem,
     m_argSlotsForFunctionsCalled(0),
     m_hasCalls(false),
     m_hasInlineArgsOpt(false),
+    m_hasInlineOverheadRemoved(false),
     m_canDoInlineArgsOpt(true),
     unoptimizableArgumentsObjReference(0),
     unoptimizableArgumentsObjReferenceInInlinees(0),

lib/Backend/Func.h

@@ -691,6 +691,7 @@ static const unsigned __int64 c_debugFillPattern8 = 0xcececececececece;
     InlineeFrameInfo*   cachedInlineeFrameInfo;
     bool                m_hasCalls: 1; // This is more accurate compared to m_isLeaf
     bool                m_hasInlineArgsOpt : 1;
+    bool                m_hasInlineOverheadRemoved : 1;
     bool                m_doFastPaths : 1;
     bool                hasBailout: 1;
     bool                hasBailoutInEHRegion : 1;

lib/Backend/Lower.cpp

@@ -14584,7 +14584,7 @@ Lowerer::LowerInlineeEnd(IR::Instr *instr)
     }
 
     // Keep InlineeEnd around as it is used by register allocator, if we have optimized the arguments stack
-    if (instr->m_func->m_hasInlineArgsOpt || (instr->m_func->GetParentFunc()->m_hasInlineArgsOpt && instr->m_func->GetHasImplicitCalls()))
+    if (instr->m_func->m_hasInlineArgsOpt || (instr->m_func->GetParentFunc()->m_hasInlineArgsOpt && !instr->m_func->m_hasInlineOverheadRemoved))
     {
         instr->FreeSrc1();
     }

test/inlining/argoptbugs.js

@@ -209,3 +209,5 @@
     func4()
     func4()
 }
+
+print("Pass")